Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on BIT_ORDER macros #351

Open
skliper opened this issue Sep 30, 2019 · 1 comment
Open

Remove dependencies on BIT_ORDER macros #351

skliper opened this issue Sep 30, 2019 · 1 comment

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

osal/src/os/inc/common_types.h defines SOFTWARE_BIG_BIT_ORDER and SOFTWARE_LITTLE_BIT_ORDER that are targeted for future deprecation.

Need to remove dependencies in cfe/fsw/cfe-core/src/inc/ccsds.h, which defines CFE_MAKE_BIG* macros, which are used in time services.

Eventually solved by EDS, but need to solve it before actually deprecating these elements.

Slight relation to #92

EDIT - the macros have been moved to cFE:

#if !defined(SOFTWARE_BIG_BIT_ORDER) && !defined(SOFTWARE_LITTLE_BIT_ORDER)
#if defined(__BYTE_ORDER) && __BYTE_ORDER == __BIG_ENDIAN || defined(__BIG_ENDIAN__) || defined(__ARMEB__) || \
defined(__THUMBEB__) || defined(__AARCH64EB__) || defined(_MIBSEB) || defined(__MIBSEB) || defined(__MIBSEB__)
/* It is a big-endian target architecture */
#define SOFTWARE_BIG_BIT_ORDER
#elif defined(__BYTE_ORDER) && __BYTE_ORDER == __LITTLE_ENDIAN || defined(__LITTLE_ENDIAN__) || defined(__ARMEL__) || \
defined(__THUMBEL__) || defined(__AARCH64EL__) || defined(_MIPSEL) || defined(__MIPSEL) || defined(__MIPSEL__) || \
defined(__i386) || defined(__i386__) || defined(__i686) || defined(__i686__) || defined(__x86_64) || \
defined(__x86_64__)
/* It is a little-endian target architecture */
#define SOFTWARE_LITTLE_BIT_ORDER
#else
#error Unknown byte order on this platform
#endif

  • Deprecate these

See also #1209

@skliper skliper added this to the 6.7.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 320. Created by jhageman on 2019-08-19T16:43:11, last modified: 2019-08-19T16:43:11

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper modified the milestones: 6.7.1, 6.7.0, 6.8.0 Sep 30, 2019
@skliper skliper removed this from the 6.8.0 milestone Nov 4, 2019
@skliper skliper added the CFS-40 label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant