Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate structure definitions in table unit test #62

Closed
skliper opened this issue Sep 30, 2019 · 8 comments
Closed

Fix duplicate structure definitions in table unit test #62

skliper opened this issue Sep 30, 2019 · 8 comments
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Similar to trac #55 for the mempool structures --

The dispatch table structure definitions are duplicated in the cfe_tbl_task.c and tbl_UT.h. The tests will break if these diverge.

A more suitable place for these would be in cfe_tbl_task_cmds.h so the same definitions can be included in both places without duplication.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 31. Created by jphickey on 2015-01-23T15:56:42, last modified: 2019-03-05T14:57:55

@skliper skliper added this to the 6.5.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-01-26 15:06:42:

Branch "trac-31-tbl_unit_test_redef" pushed for this -- commit [changeset:3e82295]

Moves the structure and macro definitions into a header file and removes the duplicates.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-04-06 11:30:38:

This is ready for review/merge

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by acudmore on 2015-04-07 12:42:35:

Concur.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-07 13:06:49:

Tested changeset [changeset:3e822954] as part of the ic-2015-03-10 merge.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-13 15:18:24:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-02-16 13:16:45:

Susie confirmed these tickets have been approved for CFE 6.5

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant