Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1335, Combine redundant switch blocks to simplify CFE_ES_CleanupObjectCallback #2612

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Logic is unchanged.
Function is simplified.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1335-combine-redundant-switch-case branch 2 times, most recently from 219a884 to a257797 Compare October 13, 2024 07:11
@thnkslprpt thnkslprpt force-pushed the fix-1335-combine-redundant-switch-case branch from a257797 to 57c8fe7 Compare October 13, 2024 07:13
@dzbaker dzbaker added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Nov 27, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 5, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Dec 10, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@dzbaker dzbaker merged commit fb8b648 into nasa:main Dec 10, 2024
21 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 10, 2024
*Combines:*

cFE equuleus-rc1+dev219
osal equuleus-rc1+dev93
PSP equuleus-rc1+dev55
cFS-GroundSystem equuleus-rc1+dev14

**Includes:**

*cFE*
- nasa/cFE#2308
- nasa/cFE#2612
- nasa/cFE#2616
- nasa/cFE#2309

*osal*
- nasa/osal#1486

*PSP*
- nasa/PSP#441

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#233
- nasa/cFS-GroundSystem#235
- nasa/cFS-GroundSystem#236

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Tvisha Andharia <tandharia@users.noreply.github.com>
Co-authored by: Chris Knight <CDKnightNASA@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-1335-combine-redundant-switch-case branch December 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate redundant switch in CFE_ES_CleanupObjectCallback
2 participants