Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #229, Update CI_LAB commands in GroundSystem Tool #230

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 17, 2022

Checklist

Describe the contribution
Fixes #229
Updates CI_LAB commands in the GroundSystem tool to be consistent with the other lab apps (prefixed with CI_LAB...)
Part of changes to the ci-lab app and the requisite changes to the cFE startup script
Aim is to standardize naming of CI_LAB functions/commands to match the predominant cFS style.

Testing performed
Tested on local machine

Expected behavior changes
No impact on behavior, but commands/functions will now be displayed with a consistent naming convention across the lab apps.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Tested on current (main) version of cFS and confirmed commands displaying correctly with the updated naming.
cFE v7.0.0-rc4+dev193
OSAL v6.0.0-rc4+dev131
PSP v1.6.0-rc4+dev55
Ground System v3.0.0-rc4+dev33
Screenshot 2022-10-17 13 25 40

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-229-standardize-ci_lab-naming branch from a1943de to 188fee7 Compare October 19, 2022 03:46
@thnkslprpt thnkslprpt marked this pull request as ready for review October 19, 2022 04:07
@dzbaker dzbaker added the CCB:Approved Indicates approval by CCB label Oct 20, 2022
@skliper
Copy link
Contributor

skliper commented Nov 9, 2022

@dzbaker - Status?

dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
@dzbaker dzbaker merged commit 75ed9d6 into nasa:main Nov 14, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul Ober <paulober@users.noreply.github.com>
@dzbaker
Copy link
Contributor

dzbaker commented Nov 14, 2022

@dzbaker - Status?

@skliper Merged!

@thnkslprpt thnkslprpt deleted the fix-229-standardize-ci_lab-naming branch November 14, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI_LAB commands
3 participants