Fix #95, reject PDUs with large bit set #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
This bit indicates that the PDU has 64-bit size and offset fields. CF currently does not support large file sizes. It needs to reject these packets as they will corrupt the data because they are not decoded properly (decode is fixed at 32 bit sizes).
jphickey
force-pushed
the
fix-95-largefile-bit
branch
from
82dc533
to
aba9487
Compare
skliper
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-01-19 APPROVED
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This bit indicates that the PDU has 64-bit size and offset fields. CF currently does not support large file sizes. It needs to reject
these packets as they will corrupt the data because they are not decoded properly (decode is fixed at 32 bit sizes).
Fixes #95
Testing performed
Build and sanity check CF
Force sending PDU with bit set, confirm CF rejects the PDU.
Expected behavior changes
CF informs the user that it received a PDU that it does not understand.
System(s) tested on
Ubuntu 21.10
Additional context
CF does not and did not support this feature, the only difference here is that it CF will now properly detect and reject a received PDU with this bit set, and inform the user of that event, instead of attempting to ingest it and doing so wrongly (likely corrupting data in the process).
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.