Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #301, Add Github workflows to bootes.x #324

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

Frank393
Copy link

@Frank393 Frank393 commented Aug 2, 2021

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Steps taken to test the contribution:

  1. Modified path for the build-documentation.yml build OSAL Guide so it could find the correct directory.
    Documentation workflow run
  2. Modified path for the static-analysis.yml cfe strict cppcheck to find the correct directory.
    Static analysis workflow run

Expected behavior changes

  • With the added workflow and Codeql we can test the previous build with GitHub action and Codeql semantic code analyzer.

System(s) tested on

  • GitHub actions ubuntu-18.04 runner

Contributor Info - All information REQUIRED for consideration of pull request
Frank I. Gonzalez Soto , GSFC Code 582 intern

@astrogeco astrogeco added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 3, 2021
Copy link
Contributor

@astrogeco astrogeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the pull_request trigger to only focus on bootes.x branch.

Change all checkout actions to checkout bootes branch instead of main

.github/workflows/build-cfs-deprecated.yml Show resolved Hide resolved
# Checks out a copy of your repository on the ubuntu-latest machine
- name: Checkout code
uses: actions/checkout@v2
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should checkout the bootes branch instead of main

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Aug 4, 2021
@astrogeco
Copy link
Contributor

CCB:2021-08-04 APPROVED

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 4, 2021
Ported workflows from Main
Updated badges in .github/workflows/README.md
@astrogeco astrogeco merged commit 273cc4e into nasa:bootes.x Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants