Replacing sprintf with snprintf to avoid overflow.

[awiswasi]

Describe the contribution
Replaced sprintf() with snprintf() to avoid overflow

Testing performed
CTest

Expected behavior changes
Protect against overflow by setting the buffer to n+1 of the char String[50] to avoid overflow that may occur.

System(s) tested on

• Hardware: PC, Raspberry Pi
• OS: Ubuntu 22.04 LTS, Windows 10

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Awf Wiswasi - California State University, Fullerton

[skliper]

Looks like whitespace changes were applied We currently use clang-format-10 w/ a config file at the cFS level, see the workflow in cFS for install and application steps.

[awiswasi]

I used the cFS clang-format and reuploaded the changes. My apologies as I am new to Clang and formatting, I was trying to contribute to the best of my knowledge. I think the whitespace formatting should be fixed now.

[jphickey]

Unfortunately this doesn't really fix the problem because it does not use the correct/actual buffer size ... and furthermore this is just one sprintf() call among many, in a tool that has long been on a list to deprecate/rewrite/replace.

Recommend to not merge this one

[dzbaker]

CCB 2 February 2023: Closing PR. Many instances of sprintf exist across elf2cfetbl, and the tool will likely be replaced in the future.