Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition sets should send their time context with telemetry requests #6928

Closed
shefalijoshi opened this issue Aug 14, 2023 · 3 comments · Fixed by #6929
Closed

Condition sets should send their time context with telemetry requests #6928

shefalijoshi opened this issue Aug 14, 2023 · 3 comments · Fixed by #6929

Comments

@shefalijoshi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some telemetry providers (like yamcs) need to know if requests are being made in real time or fixed time span mode.
Condition sets should provide this information.

Describe the solution you'd like
Send in the time context to telemetry requests so that providers can use them as needed.

Additional context
Yamcs batches requests with size limit of 1 in real time mode.

@shefalijoshi
Copy link
Contributor Author

Testing instructions:

  1. Create a condition set with multiple telemetry endpoints.
  2. Open the Network tab in chrome dev tools.
  3. Create a condition widget and style it based on the condition set created in step 1. Save it.
  4. Check that network requests are batched when possible. (like with yamcs)

@ozyx
Copy link
Contributor

ozyx commented Aug 23, 2023

Verified fixed -- Testathon 8/23/23

@khalidadil
Copy link
Contributor

khalidadil commented Aug 24, 2023

Verified Fixed in Testathon on 08/24/23. I'm seeing a parameters:batchGet in the network requests with all of the telemetries that are part of the condition set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants