Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flexible Layout]: Layout orientation and frame visibility don't update until save and renav #6942

Closed
3 of 7 tasks
ozyx opened this issue Aug 15, 2023 · 3 comments · Fixed by #6943
Closed
3 of 7 tasks

[Flexible Layout]: Layout orientation and frame visibility don't update until save and renav #6942

ozyx opened this issue Aug 15, 2023 · 3 comments · Fixed by #6943
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Milestone
Target:3.0.1

Comments

@ozyx
Copy link
Contributor

ozyx commented Aug 15, 2023

Summary

When editing the row / column orientation of a flexible layout OR the frame visibility of an individual frame in a flexible layout, the changes are not immediately represented in the view until the user saves the object and navs away/ back again.

Expected vs Current Behavior

The view should update immediately to show the changes while still in edit mode and without renav.

Steps to Reproduce

  1. Create a Flexible Layout
  2. Add a couple objects to it
  3. Go into edit mode on the Flexible Layout
  4. Click a single frame and toggle the "Frame Visibility" button
  5. Notice the frame visibility does not change
  6. Nav away / back again
  7. Notice the frame visibility has changed
  8. Repeat the same steps but for row/column orientation

Environment

  • Open MCT Version: 3.0.0
  • Deployment Type: local, any
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added type:bug bug:regression It used to work. Now it doesn't :( labels Aug 15, 2023
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 15, 2023
@ozyx ozyx self-assigned this Aug 15, 2023
@ozyx ozyx mentioned this issue Aug 16, 2023
Merged
15 tasks
@ozyx
Copy link
Contributor Author

ozyx commented Aug 16, 2023

Testing Instructions

  • Follow reproduction steps and verify that the changes reflect immediately in the view
  • Verify that the changes persist after the object is saved

ozyx added a commit that referenced this issue Aug 16, 2023
@ozyx
fix(#6942): Toggling FlexibleLayout toolbar options reflects immediat…
6c92e31 
…ely in the view (#6943)

* fix: restore reactivity of config settings

- move initialization steps to `created()` hook

- remove unnecessary `:key` binds

- fix comments

* refactor: clean up

* refactor: clean up

* refactor: lint:fix

* test(e2e): add regression test and cleanup suite

* refactor: consistency is key!

* test(fix): fix unit tests, further cleanup
ozyx added a commit that referenced this issue Aug 16, 2023
@ozyx
cherry-pick(#6943): fix(#6942): Toggling FlexibleLayout toolbar optio…
3b9fb1a 
…ns reflects immediately in the view

* fix: restore reactivity of config settings

- move initialization steps to `created()` hook

- remove unnecessary `:key` binds

- fix comments

* refactor: clean up

* refactor: clean up

* refactor: lint:fix

* test(e2e): add regression test and cleanup suite

* refactor: consistency is key!

* test(fix): fix unit tests, further cleanup
@ozyx ozyx mentioned this issue Aug 16, 2023
Merged
unlikelyzero pushed a commit that referenced this issue Aug 16, 2023
@ozyx
cherry-pick(#6943): fix(#6942): Toggling FlexibleLayout toolbar optio…
5619994 
…ns reflects immediately in the view (#6945)

* fix: restore reactivity of config settings

- move initialization steps to `created()` hook

- remove unnecessary `:key` binds

- fix comments

* refactor: clean up

* refactor: clean up

* refactor: lint:fix

* test(e2e): add regression test and cleanup suite

* refactor: consistency is key!

* test(fix): fix unit tests, further cleanup
@rukmini-bose
Copy link
Contributor

Verified Testathon 8/22/23

@charlesh88
Copy link
Contributor

Verified fixed Testathon 2023-08-22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Projects
None yet
Milestone
Target:3.0.1
Development

Successfully merging a pull request may close this issue.

fix(#6942): Toggling FlexibleLayout toolbar options reflects immediately in the view nasa/openmct
5 participants
@charlesh88 @ozyx @scottbell @unlikelyzero @rukmini-bose