Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timers don't count down or up to target date properly #7016

Closed
2 of 7 tasks
ozyx opened this issue Aug 30, 2023 · 3 comments · Fixed by #6990
Closed
2 of 7 tasks

Timers don't count down or up to target date properly #7016

ozyx opened this issue Aug 30, 2023 · 3 comments · Fixed by #6990
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Milestone
Target:3.0.2

Comments

@ozyx
Copy link
Contributor

ozyx commented Aug 30, 2023

Summary

When creating or editing a Timer, users can set a target date for the timer to count down or up to. This is broken, and on pressing play the timer always just resets to 0 and counts up from there.

Expected vs Current Behavior

The timer should count down or up to the specified target date

Steps to Reproduce

  1. Create a Timer
  2. Specify a target date
  3. Press play
  4. Note that the timer does not start counting until you reset from 0

Environment

  • Open MCT Version: 3.0.1
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added type:bug bug:regression It used to work. Now it doesn't :( labels Aug 30, 2023
@ozyx ozyx added this to the Target:3.0.2 milestone Aug 30, 2023
@ozyx ozyx self-assigned this Aug 30, 2023
ozyx added a commit that referenced this issue Aug 30, 2023
@ozyx
fix(#7016): timers count down or up to a target date
f0e97d9
ozyx added a commit that referenced this issue Aug 30, 2023
@ozyx
fix(#7016): timers count down or up to a target date
89d0413
@ozyx ozyx mentioned this issue Aug 30, 2023
Merged
15 tasks
@msf-caesar
Copy link

Try with resetting the timer to the specified target date before pressing play. This way, the timer should start counting down or up from the desired target date instead of resetting to 0.

scottbell added a commit that referenced this issue Sep 5, 2023
@ozyx @scottbell @unlikelyzero
Fix and re-enable disabled unit test suites (#6990)
0be106f 
* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
ozyx added a commit that referenced this issue Sep 11, 2023
@ozyx @scottbell @unlikelyzero
cherry-pick(#6990): Fix and re-enable disabled unit test suites
029a67d 
* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
@ozyx ozyx mentioned this issue Sep 11, 2023
Closed
ozyx added a commit that referenced this issue Sep 12, 2023
@ozyx @scottbell @unlikelyzero
cherry-pick(#6990): Fix and re-enable disabled unit test suites
598306d 
* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
@ozyx ozyx mentioned this issue Sep 12, 2023
Merged
ozyx added a commit that referenced this issue Sep 12, 2023
@ozyx @scottbell @unlikelyzero
cherry-pick(#6990): Fix and re-enable disabled unit test suites
85ba502 
* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
unlikelyzero added a commit that referenced this issue Sep 12, 2023
@ozyx @scottbell @unlikelyzero
cherry-pick(#6990): Fix and re-enable disabled unit test suites (#7049)
b923af8 
* fix: register event listeners etc in `created()` hook

* fix: initialize `stalenessSubscription` before composition load and in `created()` hook

* refactor(test): make `openmct` const

* refactor: update overlayPlot spec to Vue 3 and fix tests

* refactor: fix eslint errors

* refactor: move initialization steps to `created()` hook

* test: re-enable and fix stackedPlot test suite

* fix: `hideTree=true` hides the tree again

* fix: add back in check on mount

* test: fix Layout tests

* fix: BarGraph test

* fix: plot inspector tests

* fix: reenable grand search tests

* fix: inspectorStyles test suite

* fix: re-enable most timeline tests

* fix: no need to hideTree in appactions

* fix: re-enable more tests

* test: re-enable more tests

* test: re-enable most plot tests

* chore: `lint:fix`

* test: re-enable timelist suite

* fix(#7016): timers count down or up to a target date

* test: add regression tests to cover disabled unit tests

* refactor: lint:fix

* refactor: no need for momentjs here

* fix: timerAction missed refactor

* fix: ensure timestamp is always UTC string

* test: use role selectors

* docs: add instructions for clock override in e2e

* docs: update

* Update readme

* lint

* spelling fixes

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: John Hill <john.c.hill@nasa.gov>
@ozyx
Copy link
Contributor Author

ozyx commented Sep 12, 2023

Testing Instructions

  • Create a new Timer with defaults
  • Verify that start, stop, pause, restart at 0 all function as expected
  • Create a new Timer with a target date in the future
  • Verify that the Timer counts down appropriately and all actions work as expected
  • Create a new Timer with a target date in the past
  • Verify that the Timer counts up appropriately and all actions work as expected

@charlesh88
Copy link
Contributor

Verified fixed Testathon 2023-09-12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Milestone
Target:3.0.2
Development

Successfully merging a pull request may close this issue.

Fix and re-enable disabled unit test suites nasa/openmct
5 participants
@charlesh88 @ozyx @scottbell @unlikelyzero @msf-caesar