Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double clicking on an image in a layout should embiggen it but does not. #7055

Closed
3 of 7 tasks
akhenry opened this issue Sep 13, 2023 · 2 comments · Fixed by #7308
Closed
3 of 7 tasks

Double clicking on an image in a layout should embiggen it but does not. #7055

akhenry opened this issue Sep 13, 2023 · 2 comments · Fixed by #7308
Labels
bug:regression It used to work. Now it doesn't :( severity:medium source:user request type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Sep 13, 2023 •
edited
Loading

Summary

When an image is embedded in a display layout a user should be able to double click on the image to show a larger version of that image.

Workaround

  1. Use the "Large View" button
  2. Double click on the gray background around the image itself.

Steps to Reproduce

  1. Create a layout
  2. Drop an image into the layout
  3. Save and Finish Editing
  4. Double click on the image
  5. Observe that nothing happens.
  6. Double click on the gray area around the image
  7. Observe that the image is enlarged as expected.

Environment

  • Open MCT Version: 3.0.1+
  • Deployment Type: MMOC, Dev
  • Browser: Chrome 116.0.5845.187

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@akhenry akhenry added this to the Target:3.1.0 milestone Sep 13, 2023
@unlikelyzero unlikelyzero added bug:regression It used to work. Now it doesn't :( source:user request labels Sep 13, 2023
@akhenry akhenry modified the milestones: Target:3.1.0, 3.2.0 Oct 2, 2023
@unlikelyzero unlikelyzero removed this from the Target:3.2.0 milestone Oct 27, 2023
@marcelo-earth marcelo-earth mentioned this issue Dec 17, 2023
Merged
15 tasks
ozyx added a commit that referenced this issue Jan 14, 2024
@marcelo-earth @ozyx
fix(#7055): Expand on image with double click (#7308)
11f3ce9 
* Add double click event to expand image view

* Add performance tests for large view and close
button

* Add example imagery in flexible layout to test double-click functionality

* Remove click event listener in ImageryView.vue

* Move test to 'Example Imagery in Flexible layout'

* Refactor exampleImagery.e2e.spec.js

* Remove unnecessary code for opening and closing
large view in imagery.contract.per.spec.js

* Replace pageSelector with getByRole on double-click image test

* Add role and aria-label to focused image

* Remove unnecessary code and role attribute from ImageryView.vue

---------

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Jan 17, 2024
@ozyx
Copy link
Contributor

ozyx commented Jan 18, 2024 •
edited
Loading

Testing Instructions

  1. Create a layout
  2. Drop an example imagery into the layout
  3. Navigate to it
  4. Double click on the image, confirm that it embiggens
  5. Close
  6. Double click on the grey border around the image, confirm it does not embiggen

@rukmini-bose
Copy link
Contributor

Verified Testathon locally on 1/18/2024

@akhenry akhenry added the verified Tested or intentionally closed label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:medium source:user request type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7055): Expand on image with double click marcelo-earth/openmct
4 participants
@akhenry @ozyx @unlikelyzero @rukmini-bose