Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e test] in notebook.e2e.spec.js #7226

Closed
saram7619 opened this issue Nov 13, 2023 · 3 comments · Fixed by #7236
Closed

[e2e test] in notebook.e2e.spec.js #7226

saram7619 opened this issue Nov 13, 2023 · 3 comments · Fixed by #7236
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@saram7619
Copy link
Contributor

Summary

Using playwright, I completed the

test.fixme('Can create a Notebook Object') //Create domain object and Newly created notebook should have one section and one page
@saram7619 saram7619 added the type:maintenance tests, chores, or project maintenance label Nov 13, 2023
@ozyx
Copy link
Contributor

ozyx commented Nov 13, 2023

Awesome! Please go ahead and open a pull request once you're ready for it to be reviewed.

@saram7619
Copy link
Contributor Author

Do I need to do a draft pr or just a pr?

@ozyx
Copy link
Contributor

ozyx commented Nov 13, 2023

Do I need to do a draft pr or just a pr?

Just a regular PR

@saram7619 saram7619 mentioned this issue Nov 14, 2023
Merged
15 tasks
@ozyx ozyx closed this as completed in #7236 Dec 4, 2023
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 8, 2024
@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

[CLA Received] wrote an e2e test for can create a notebook object saram7619/openmct
3 participants
@ozyx @unlikelyzero @saram7619