Toggle between showing aggregate stacked plot legend or per-plot legend #6758
Conversation
…not show. Use the Plot component in the StackedPlotItem component for simplicity and show/hide sub-legends as needed.
Current Playwright Test Results Summary✅ 13 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/11/2023 11:16:33pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f64d566 Started: 07/11/2023 11:13:40pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
15.38% (4)4 / 26 runsfailed over last 7 days |
65.38% (17)17 / 26 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 123 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/11/2023 11:16:33pm UTC)
⚠️ Flakes
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
6.41% (5)5 / 78 runsfailed over last 7 days |
74.36% (58)58 / 78 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6758 +/- ##
=======================================
Coverage 53.75% 53.76%
=======================================
Files 624 624
Lines 24848 24879 +31
Branches 2493 2498 +5
=======================================
+ Hits 13358 13375 +17
- Misses 10822 10833 +11
- Partials 668 671 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Two small changes and 2 issues I found. It seams staleness styling is a little messed up now (example images) and the other issue is that position of the legend doesn't seem to be working anymore?
Before:
After:
This is the same plot, but you can see the position is set to bottom which is working in the older version. The issue with styling seems to be the border is missing and the legend item styling seems off.
I took a look at the staleness issue. It seems that And Jamie's observation about the legend positions not working is true– they don't seem to work anymore. |
…y lookup, fix bug with staleness
There was a problem hiding this comment.
It looks like the staleness bux is half fixed. While we now see the correct border an icon at the bottom left of the plot, we also see the icon on the legend, which shouldn't be there. I believe that in the legend, the data point should only be highlighted in cyan.
What we are seeing (notice the legend):
What it should look like:
In addition, I had a thought– if users cannot change the positioning of the legend when we are the "per plot" setting is toggled on (which was a conscious UI decision), can we just hide that setting unless the user toggles off the setting? Otherwise, I can see how it can cause confusion to a user.
Other than that, all looks good!
|
I didn't see anything other than what @rukmini-bose pointed out. I did notice, you only get the messed up icons when "per plot" legend is selected. It's fine when it's all in one line. |
Closes #6792 and VIPERRQSTS-239
Describe your changes:
New option to show/hide stacked plot aggregate legend - defaulted to …not show.
Use the Plot component in the StackedPlotItem component for simplicity
Add logic to how/hide per plot legends as needed.
All Submissions:
Author Checklist
Reviewer Checklist