Wait for bounds change to reset telemetry collection data #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/31/2023 06:14:55pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f6f2a46 Started: 07/31/2023 06:12:42pm UTC Current Playwright Test Results Summary✅ 131 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/31/2023 06:14:55pm UTC)
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 75 runsfailed over last 7 days |
18.67% (14)14 / 75 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.33% (1)1 / 75 runfailed over last 7 days |
18.67% (14)14 / 75 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
1.39% (1)1 / 72 runfailed over last 7 days |
11.11% (8)8 / 72 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery Object Can use independent time conductor to change time
Retry 2 • Retry 1 • Initial Attempt |
18.29% (15)15 / 82 runsfailed over last 7 days |
15.85% (13)13 / 82 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6857 +/- ##
==========================================
+ Coverage 47.79% 48.63% +0.83%
==========================================
Files 643 643
Lines 25618 25626 +8
Branches 2507 2505 -2
==========================================
+ Hits 12244 12462 +218
+ Misses 12897 12669 -228
- Partials 477 495 +18
*This pull request uses carry forward flags. Click here to find out more.
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
khalidadil
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6813
Describe your changes:
Reset and re-request telemetry only after receiving bounds following a mode change
All Submissions:
Author Checklist
Reviewer Checklist