Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress deprecation warnings to once per unique args #6875

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 1, 2023

Closes #6870

Describe your changes:

Suppresses deprecation warnings in the TimeAPI to once per unique args

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.0.0 milestone Aug 1, 2023
@ozyx ozyx requested review from akhenry and jvigliotta August 1, 2023 21:14
@deploysentinel
Copy link

deploysentinel bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/01/2023 11:50:47pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 1ebb081

Started: 08/01/2023 11:48:22pm UTC

⚠️ Flakes

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1Initial Attempt
0% (0) 0 / 54 runs
failed over last 7 days
3.70% (2) 2 / 54 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 131 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/01/2023 11:50:47pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 1ebb081

Started: 08/01/2023 11:00:24pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
4.26% (4) 4 / 94 runs
failed over last 7 days
11.70% (11) 11 / 94 runs
flaked over last 7 days

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
10.58% (11) 11 / 104 runs
failed over last 7 days
39.42% (41) 41 / 104 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 2Retry 1Initial Attempt
1.14% (1) 1 / 88 run
failed over last 7 days
13.64% (12) 12 / 88 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 91 runs
failed over last 7 days
17.58% (16) 16 / 91 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
2.50% (3) 3 / 120 runs
failed over last 7 days
17.50% (21) 21 / 120 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6875 (1ebb081) into master (95e6860) will increase coverage by 1.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6875      +/-   ##
==========================================
+ Coverage   46.91%   48.27%   +1.36%     
==========================================
  Files         643      643              
  Lines       25622    25629       +7     
  Branches     2505     2505              
==========================================
+ Hits        12020    12372     +352     
+ Misses      13126    12783     -343     
+ Partials      476      474       -2     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (ø) Carriedforward from 95e6860
e2e-stable 56.96% <100.00%> (+3.90%) ⬆️
unit 38.79% <100.00%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/api/time/TimeContext.js 81.54% <100.00%> (+0.80%) ⬆️

... and 47 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e6860...1ebb081. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 1, 2023
@akhenry akhenry merged commit 0421936 into master Aug 2, 2023
@akhenry akhenry deleted the mct6870 branch August 2, 2023 16:11
ozyx added a commit that referenced this pull request Aug 2, 2023
…args (#6881)

fix: suppress deprecation warnings to once per unique args (#6875)

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Aug 2, 2023

Verified Fixed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress deprecation warnings in production mode
3 participants