Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add vue3 to eslint, fix errors, and modify lint script #6910

Merged
merged 3 commits into from
Aug 14, 2023
Merged

chore: add vue3 to eslint, fix errors, and modify lint script #6910

merged 3 commits into from
Aug 14, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 9, 2023

Closes #6909

Describe your changes:

Updates our eslint config to include Vue 3 recommended rules. Edits some existing and non-pertinent rules to be warnings. Splits our linting step into two discrete steps, one that lints against *.js files and accepts no warnings, and another that lints against *.vue files and produces warnings in addition to errors. This is to help guide developers on what needs to change in order for us to complete the migration to Vue 3.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.1.0 milestone Aug 9, 2023
@ozyx ozyx requested a review from unlikelyzero August 9, 2023 18:34
@deploysentinel
Copy link

deploysentinel bot commented Aug 9, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/14/2023 05:03:03pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: f063941

Started: 08/14/2023 05:00:51pm UTC

View Detailed Build Results

Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/14/2023 05:03:03pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: f063941

Started: 08/14/2023 04:25:06pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt
0% (0) 0 / 101 runs
failed over last 7 days
37.62% (38) 38 / 101 runs
flaked over last 7 days

View Detailed Build Results

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #6910 (f063941) into master (50694f6) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6910      +/-   ##
==========================================
- Coverage   48.39%   48.32%   -0.08%     
==========================================
  Files         643      643              
  Lines       25627    25627              
  Branches     2496     2496              
==========================================
- Hits        12401    12383      -18     
- Misses      12751    12768      +17     
- Partials      475      476       +1
Flag Coverage Δ *Carryforward flag
e2e-full 42.08% <ø> (ø) Carriedforward from 50694f6
e2e-stable 56.43% <ø> (-0.74%) ⬇️
unit 38.75% <0.00%> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/timeConductor/ConductorClock.vue 17.85% <0.00%> (ø)

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50694f6...f063941. Read the comment docs.

@ozyx ozyx requested a review from unlikelyzero August 14, 2023 16:21
unlikelyzero
unlikelyzero approved these changes Aug 14, 2023
View reviewed changes
.eslintrc.js
@@ -28,6 +28,8 @@ module.exports = {
}
},
rules: {
'vue/no-deprecated-dollar-listeners-api': 'warn',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which of these two are due to our proxy migration path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both warnings are required in order to upgrade fully to Vue 3. The fix is not trivial (though not complicated), so I'm allowing warnings here so we can work these out and eventually disallow warnings again once we upgrade.

package.json
@@ -81,7 +81,7 @@
"clean-test-lint": "npm run clean; npm install; npm run test; npm run lint; npm run lint:spelling",
"start": "npx webpack serve --config ./.webpack/webpack.dev.js",
"start:coverage": "npx webpack serve --config ./.webpack/webpack.coverage.js",
"lint": "eslint example src e2e --ext .js,.vue openmct.js --max-warnings=0",
"lint": "eslint example src e2e --ext .js openmct.js --max-warnings=0 && eslint example src --ext .vue",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 14, 2023
@ozyx ozyx enabled auto-merge (squash) August 14, 2023 16:59
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 14, 2023
@ozyx ozyx merged commit f3b819a into master Aug 14, 2023
@ozyx ozyx deleted the vue3-eslint-config branch August 14, 2023 17:03
ozyx added a commit that referenced this pull request Aug 14, 2023
@ozyx
cherry-pick(#6910): chore: add vue3 to eslint, fix errors, and modify…
8346d3c 
… lint script
ozyx added a commit that referenced this pull request Aug 16, 2023
@ozyx @unlikelyzero
cherry-pick(#6910): chore: add vue3 to eslint, fix errors, and modify…
5b7b722 
… lint script (#6935)

* cherry-pick(#6910): chore: add vue3 to eslint, fix errors, and modify lint script

* refactor: lint:fix

---------

Co-authored-by: John Hill <john.c.hill@nasa.gov>
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlikelyzero unlikelyzero unlikelyzero approved these changes

Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:3.1.0
Development

Successfully merging this pull request may close these issues.

Update eslint configuration to include Vue 3 rules
3 participants
@ozyx @unlikelyzero @shefalijoshi