Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition sets now provide the timeContext they're using when sending requests #6929

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 14, 2023

Closes #6928

Describe your changes:

Send in the timeContext as request options for lad requests from condition sets. Some providers (like Yamcs) use the information from the timeContext (realtime vs fixed timespan mode etc.).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@shefalijoshi shefalijoshi requested a review from scottbell August 14, 2023 18:12
@deploysentinel
Copy link

deploysentinel bot commented Aug 14, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/15/2023 05:32:19pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 86da66d

Started: 08/15/2023 05:30:25pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/15/2023 05:32:19pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 86da66d

Started: 08/15/2023 04:31:23pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0.76% (1) 1 / 131 run
failed over last 7 days
45.04% (59) 59 / 131 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 128 runs
failed over last 7 days
42.97% (55) 55 / 128 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #6929 (86da66d) into master (c53073b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6929      +/-   ##
==========================================
- Coverage   48.39%   48.35%   -0.04%     
==========================================
  Files         643      643              
  Lines       25629    25629              
  Branches     2496     2496              
==========================================
- Hits        12402    12393       -9     
- Misses      12752    12760       +8     
- Partials      475      476       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.08% <ø> (+0.03%) ⬆️ Carriedforward from c5e53f0
e2e-stable 57.12% <ø> (-0.05%) ⬇️
unit 38.75% <ø> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ugins/condition/criterion/AllTelemetryCriterion.js 43.33% <ø> (ø)
.../plugins/condition/criterion/TelemetryCriterion.js 73.98% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53073b...86da66d. Read the comment docs.

@ozyx
Copy link
Contributor

ozyx commented Aug 14, 2023

@shefalijoshi blocked due to failing unit test

@shefalijoshi shefalijoshi enabled auto-merge (squash) August 15, 2023 17:06
@shefalijoshi shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 15, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 15, 2023
@shefalijoshi shefalijoshi merged commit 87feb0d into master Aug 15, 2023
@shefalijoshi shefalijoshi deleted the fix-condition-set-request-lad-batching branch August 15, 2023 17:32
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 15, 2023
@ozyx
Copy link
Contributor

ozyx commented Aug 15, 2023

@shefalijoshi let's cherry-pick this one onto release/3.0.1 before we forget

shefalijoshi added a commit that referenced this pull request Aug 18, 2023
… using when sending requests (#6929)

* Send in the timeContext for requests

* Fix failing test

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
ozyx pushed a commit that referenced this pull request Aug 21, 2023
…e using when sending requests (#6959)

cherry-pick(6929): Condition sets now provide the timeContext they're using when sending requests (#6929)

* Send in the timeContext for requests

* Fix failing test

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition sets should send their time context with telemetry requests
3 participants