Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Stabilize ITC tests #6933

Merged
merged 9 commits into from
Aug 16, 2023
Merged

fix(e2e): Stabilize ITC tests #6933

merged 9 commits into from
Aug 16, 2023

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Aug 14, 2023

Closes #6931
Closes #6932

Describe your changes:

Stabilizes the ITC e2e tests by waiting for the ITC popup to be present in the Viewport before continuing. Also moves the ITC initialization logic to the created() hook since it does not have to wait until the component is rendered before doing the setup (no $refs needed). Adds some JSDocs as well.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.0.1 milestone Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #6933 (d0b3279) into master (6c92e31) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6933      +/-   ##
==========================================
- Coverage   48.37%   48.30%   -0.08%     
==========================================
  Files         643      643              
  Lines       25631    25631              
  Branches     2496     2496              
==========================================
- Hits        12399    12380      -19     
- Misses      12756    12774      +18     
- Partials      476      477       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.03% <ø> (ø) Carriedforward from 1d42c4e
e2e-stable 57.03% <ø> (-0.12%) ⬇️
unit 38.75% <ø> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...Conductor/independent/IndependentTimeConductor.vue 0.00% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c92e31...d0b3279. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Aug 14, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/16/2023 07:01:56pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: d0b3279

Started: 08/16/2023 06:59:44pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/16/2023 07:01:56pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: d0b3279

Started: 08/16/2023 06:48:25pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.22% (3) 3 / 135 runs
failed over last 7 days
39.26% (53) 53 / 135 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 165 runs
failed over last 7 days
57.58% (95) 95 / 165 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx requested a review from unlikelyzero August 16, 2023 17:51
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 16, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 16, 2023
@ozyx ozyx enabled auto-merge (squash) August 16, 2023 18:00
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 16, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 16, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 16, 2023
@ozyx ozyx merged commit f21685e into master Aug 16, 2023
@ozyx ozyx deleted the stabilize-ITC-tests branch August 16, 2023 19:02
ozyx added a commit that referenced this pull request Aug 16, 2023
* fix(ITC): initialize ITC in `created()` hook

* fix(e2e): stabilize ITC tests

* docs: add JSDocs

* refactor: lint:fix

* test(e2e): add comment and assertion

* refactor: lint:fix
ozyx added a commit that referenced this pull request Aug 16, 2023
* cherry-pick(#6933): fix(e2e): Stabilize ITC tests

* fix(ITC): initialize ITC in `created()` hook

* fix(e2e): stabilize ITC tests

* docs: add JSDocs

* refactor: lint:fix

* test(e2e): add comment and assertion

* refactor: lint:fix

* fix: cherry-pick over existing tagging fixes

* fix: cherry-pick over more test fixes

---------

Co-authored-by: John Hill <john.c.hill@nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants