-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): Stabilize ITC tests #6933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6933 +/- ##
==========================================
- Coverage 48.37% 48.30% -0.08%
==========================================
Files 643 643
Lines 25631 25631
Branches 2496 2496
==========================================
- Hits 12399 12380 -19
- Misses 12756 12774 +18
- Partials 476 477 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 07:01:56pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: d0b3279 Started: 08/16/2023 06:59:44pm UTC Current Playwright Test Results Summary✅ 134 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 07:01:56pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.22% (3)3 / 135 runsfailed over last 7 days |
39.26% (53)53 / 135 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 165 runsfailed over last 7 days |
57.58% (95)95 / 165 runsflaked over last 7 days |
* fix(ITC): initialize ITC in `created()` hook * fix(e2e): stabilize ITC tests * docs: add JSDocs * refactor: lint:fix * test(e2e): add comment and assertion * refactor: lint:fix
* cherry-pick(#6933): fix(e2e): Stabilize ITC tests * fix(ITC): initialize ITC in `created()` hook * fix(e2e): stabilize ITC tests * docs: add JSDocs * refactor: lint:fix * test(e2e): add comment and assertion * refactor: lint:fix * fix: cherry-pick over existing tagging fixes * fix: cherry-pick over more test fixes --------- Co-authored-by: John Hill <john.c.hill@nasa.gov>
Closes #6931
Closes #6932
Describe your changes:
Stabilizes the ITC e2e tests by waiting for the ITC popup to be present in the Viewport before continuing. Also moves the ITC initialization logic to the
created()
hook since it does not have to wait until the component is rendered before doing the setup (no $refs needed). Adds some JSDocs as well.All Submissions:
Author Checklist
Reviewer Checklist