fix(#6942): Toggling FlexibleLayout toolbar options reflects immediately in the view #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move initialization steps to `created()` hook - remove unnecessary `:key` binds - fix comments
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 05:52:00pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 3162a62 Started: 08/16/2023 05:49:39pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1 • Initial Attempt |
0% (0)0 / 51 runsfailed over last 7 days |
5.88% (3)3 / 51 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 134 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/16/2023 05:52:00pm UTC)
⚠️ Flakes
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 127 runsfailed over last 7 days |
47.24% (60)60 / 127 runsflaked over last 7 days |
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 126 runsfailed over last 7 days |
45.24% (57)57 / 126 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Plot Tagging Tags work with Overlay Plots
Retry 1 • Initial Attempt |
10.32% (13)13 / 126 runsfailed over last 7 days |
26.19% (33)33 / 126 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 158 runsfailed over last 7 days |
57.59% (91)91 / 158 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6943 +/- ##
==========================================
+ Coverage 48.33% 48.36% +0.02%
==========================================
Files 643 643
Lines 25629 25631 +2
Branches 2496 2496
==========================================
+ Hits 12389 12396 +7
+ Misses 12767 12759 -8
- Partials 473 476 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
scottbell
approved these changes
Aug 16, 2023
unlikelyzero
approved these changes
Aug 16, 2023
ozyx
added a commit
that referenced
this pull request
Aug 16, 2023
…ns reflects immediately in the view * fix: restore reactivity of config settings - move initialization steps to `created()` hook - remove unnecessary `:key` binds - fix comments * refactor: clean up * refactor: clean up * refactor: lint:fix * test(e2e): add regression test and cleanup suite * refactor: consistency is key! * test(fix): fix unit tests, further cleanup
unlikelyzero
pushed a commit
that referenced
this pull request
Aug 16, 2023
…ns reflects immediately in the view (#6945) * fix: restore reactivity of config settings - move initialization steps to `created()` hook - remove unnecessary `:key` binds - fix comments * refactor: clean up * refactor: clean up * refactor: lint:fix * test(e2e): add regression test and cleanup suite * refactor: consistency is key! * test(fix): fix unit tests, further cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6942
Describe your changes:
Fixes reactivity issues with toggling toolbar options tied to domainObject configuration in the Flexible Layout (Row/Column Layout and Frame Visibility).
Also adds a regression test and cleans up the Flexible Layout suite a tiny bit.
All Submissions:
Author Checklist
Reviewer Checklist