cherry-pick(#6943): fix(#6942): Toggling FlexibleLayout toolbar options reflects immediately in the view #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns reflects immediately in the view * fix: restore reactivity of config settings - move initialization steps to `created()` hook - remove unnecessary `:key` binds - fix comments * refactor: clean up * refactor: clean up * refactor: lint:fix * test(e2e): add regression test and cleanup suite * refactor: consistency is key! * test(fix): fix unit tests, further cleanup
unlikelyzero
approved these changes
Aug 16, 2023
Current Playwright Test Results Summary✅ 135 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/16/2023 07:21:05pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time conductor input fields real-time mode preserve offsets and url params when switching between fixed and real-time mode
Retry 1 • Initial Attempt |
0.78% (1)1 / 129 runfailed over last 7 days |
1.55% (2)2 / 129 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.16% (3)3 / 139 runsfailed over last 7 days |
40.29% (56)56 / 139 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1 • Initial Attempt |
14.16% (16)16 / 113 runsfailed over last 7 days |
30.09% (34)34 / 113 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 14 Passing
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/16/2023 07:21:05pm UTC)
Run Details
Running Workflow e2e-couchdb on Github Actions
Commit: 3b9fb1a
Started: 08/16/2023 06:24:10pm UTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move initialization steps to
created()hookremove unnecessary
:keybindsfix comments
refactor: clean up
refactor: clean up
refactor: lint:fix
test(e2e): add regression test and cleanup suite
refactor: consistency is key!
test(fix): fix unit tests, further cleanup
Issue #6942