cherry-pick(#6927): Recent objects do not update when object names are changed #6949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix tree name issue * add name to key, and name observers to recent objects * no need to change key * make more of app reactive to name changes * fix browse bar and document title * listen in properties for name changes * add tests for renaming * yeah spelling linter * add semantic tags to forms and fixup tests * change purpose * actually delete the listener * ensuring deletion --------- Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/17/2023 09:28:09am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 89b4c6e Started: 08/17/2023 09:22:03am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
11.86% (7)7 / 59 runsfailed over last 7 days |
25.42% (15)15 / 59 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 137 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/17/2023 09:28:09am UTC)
⚠️ Flakes
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
11.76% (12)12 / 102 runsfailed over last 7 days |
33.33% (34)34 / 102 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 178 runsfailed over last 7 days |
55.62% (99)99 / 178 runsflaked over last 7 days |
📄 functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Autoscale User can set autoscale with a valid range @snapshot
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 148 runsfailed over last 7 days |
4.73% (7)7 / 148 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## release/3.0.1 #6949 +/- ##
================================================
Coverage ? 48.30%
================================================
Files ? 644
Lines ? 25701
Branches ? 2509
================================================
Hits ? 12416
Misses ? 12804
Partials ? 481
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
unlikelyzero
approved these changes
Aug 17, 2023
ozyx
changed the title
ozyx
deleted the
6818-recent-objects-do-not-update-when-object-names-are-changed-cherry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6818
Describe your changes:
Cherry pick this into
release/3.0.1All Submissions:
Author Checklist
Reviewer Checklist