Fix and re-enable disabled unit test suites #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #6990 +/- ##
==========================================
+ Coverage 48.31% 55.48% +7.17%
==========================================
Files 643 643
Lines 25730 25726 -4
Branches 2512 2512
==========================================
+ Hits 12431 14275 +1844
+ Misses 12819 10761 -2058
- Partials 480 690 +210
*This pull request uses carry forward flags. Click here to find out more.
... and 76 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/05/2023 08:52:40am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: d7a2969 Started: 09/05/2023 08:50:23am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
15% (6)6 / 40 runsfailed over last 7 days |
20% (8)8 / 40 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 138 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 09/05/2023 08:52:40am UTC)
⚠️ Flakes
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.15% (2)2 / 93 runsfailed over last 7 days |
41.94% (39)39 / 93 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
4.35% (4)4 / 92 runsfailed over last 7 days |
19.57% (18)18 / 92 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 94 runsfailed over last 7 days |
56.38% (53)53 / 94 runsflaked over last 7 days |
…n `created()` hook
unlikelyzero
reviewed
Sep 1, 2023
e2e/README.md
Outdated
| @@ -381,6 +381,27 @@ For best practices with regards to mocking network responses, see our [couchdb.e | |||
|
|
|||
| The following contains a list of tips and tricks which don't exactly fit into a FAQ or Best Practices doc. | |||
|
|
|||
| - Overriding the Clock | |||
There was a problem hiding this comment.
Overriding the Browser's Clock to control time based elements
unlikelyzero
requested changes
Sep 1, 2023
unlikelyzero
approved these changes
Sep 3, 2023
15 tasks
scottbell
approved these changes
Sep 5, 2023
ozyx
added a commit
that referenced
this pull request
Sep 11, 2023
* fix: register event listeners etc in `created()` hook * fix: initialize `stalenessSubscription` before composition load and in `created()` hook * refactor(test): make `openmct` const * refactor: update overlayPlot spec to Vue 3 and fix tests * refactor: fix eslint errors * refactor: move initialization steps to `created()` hook * test: re-enable and fix stackedPlot test suite * fix: `hideTree=true` hides the tree again * fix: add back in check on mount * test: fix Layout tests * fix: BarGraph test * fix: plot inspector tests * fix: reenable grand search tests * fix: inspectorStyles test suite * fix: re-enable most timeline tests * fix: no need to hideTree in appactions * fix: re-enable more tests * test: re-enable more tests * test: re-enable most plot tests * chore: `lint:fix` * test: re-enable timelist suite * fix(#7016): timers count down or up to a target date * test: add regression tests to cover disabled unit tests * refactor: lint:fix * refactor: no need for momentjs here * fix: timerAction missed refactor * fix: ensure timestamp is always UTC string * test: use role selectors * docs: add instructions for clock override in e2e * docs: update * Update readme * lint * spelling fixes --------- Co-authored-by: Scott Bell <scott@traclabs.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
ozyx
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: register event listeners etc in `created()` hook * fix: initialize `stalenessSubscription` before composition load and in `created()` hook * refactor(test): make `openmct` const * refactor: update overlayPlot spec to Vue 3 and fix tests * refactor: fix eslint errors * refactor: move initialization steps to `created()` hook * test: re-enable and fix stackedPlot test suite * fix: `hideTree=true` hides the tree again * fix: add back in check on mount * test: fix Layout tests * fix: BarGraph test * fix: plot inspector tests * fix: reenable grand search tests * fix: inspectorStyles test suite * fix: re-enable most timeline tests * fix: no need to hideTree in appactions * fix: re-enable more tests * test: re-enable more tests * test: re-enable most plot tests * chore: `lint:fix` * test: re-enable timelist suite * fix(#7016): timers count down or up to a target date * test: add regression tests to cover disabled unit tests * refactor: lint:fix * refactor: no need for momentjs here * fix: timerAction missed refactor * fix: ensure timestamp is always UTC string * test: use role selectors * docs: add instructions for clock override in e2e * docs: update * Update readme * lint * spelling fixes --------- Co-authored-by: Scott Bell <scott@traclabs.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
ozyx
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: register event listeners etc in `created()` hook * fix: initialize `stalenessSubscription` before composition load and in `created()` hook * refactor(test): make `openmct` const * refactor: update overlayPlot spec to Vue 3 and fix tests * refactor: fix eslint errors * refactor: move initialization steps to `created()` hook * test: re-enable and fix stackedPlot test suite * fix: `hideTree=true` hides the tree again * fix: add back in check on mount * test: fix Layout tests * fix: BarGraph test * fix: plot inspector tests * fix: reenable grand search tests * fix: inspectorStyles test suite * fix: re-enable most timeline tests * fix: no need to hideTree in appactions * fix: re-enable more tests * test: re-enable more tests * test: re-enable most plot tests * chore: `lint:fix` * test: re-enable timelist suite * fix(#7016): timers count down or up to a target date * test: add regression tests to cover disabled unit tests * refactor: lint:fix * refactor: no need for momentjs here * fix: timerAction missed refactor * fix: ensure timestamp is always UTC string * test: use role selectors * docs: add instructions for clock override in e2e * docs: update * Update readme * lint * spelling fixes --------- Co-authored-by: Scott Bell <scott@traclabs.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
unlikelyzero
added a commit
that referenced
this pull request
Sep 12, 2023
* fix: register event listeners etc in `created()` hook * fix: initialize `stalenessSubscription` before composition load and in `created()` hook * refactor(test): make `openmct` const * refactor: update overlayPlot spec to Vue 3 and fix tests * refactor: fix eslint errors * refactor: move initialization steps to `created()` hook * test: re-enable and fix stackedPlot test suite * fix: `hideTree=true` hides the tree again * fix: add back in check on mount * test: fix Layout tests * fix: BarGraph test * fix: plot inspector tests * fix: reenable grand search tests * fix: inspectorStyles test suite * fix: re-enable most timeline tests * fix: no need to hideTree in appactions * fix: re-enable more tests * test: re-enable more tests * test: re-enable most plot tests * chore: `lint:fix` * test: re-enable timelist suite * fix(#7016): timers count down or up to a target date * test: add regression tests to cover disabled unit tests * refactor: lint:fix * refactor: no need for momentjs here * fix: timerAction missed refactor * fix: ensure timestamp is always UTC string * test: use role selectors * docs: add instructions for clock override in e2e * docs: update * Update readme * lint * spelling fixes --------- Co-authored-by: Scott Bell <scott@traclabs.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7016
Closes #7019
Describe your changes:
Fixes and re-enables most unit test suites that were disabled while we were working through the Vue 3 compat upgrade. Fixes a couple of issues and adds e2e coverage for suites we were unable to re-enable.
All Submissions:
Author Checklist
Reviewer Checklist