-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mojibake #7073
Fix mojibake #7073
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/20/2023 08:36:31pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: cd56997 Started: 09/20/2023 08:29:50pm UTC Current Playwright Test Results Summary✅ 139 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/20/2023 08:36:31pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 114 runsfailed over last 7 days |
43.86% (50)50 / 114 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
1.75% (2)2 / 114 runsfailed over last 7 days |
36.84% (42)42 / 114 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
3.64% (4)4 / 110 runsfailed over last 7 days |
17.27% (19)19 / 110 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Plot Tagging Tags work with Overlay Plots
Retry 2 • Retry 1 • Initial Attempt |
33.33% (36)36 / 108 runsfailed over last 7 days |
15.74% (17)17 / 108 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.37% (2)2 / 146 runsfailed over last 7 days |
49.32% (72)72 / 146 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
1.82% (1)1 / 55 runfailed over last 7 days |
78.18% (43)43 / 55 runsflaked over last 7 days |
Add charset preamble to generated css
Fix mojibake (#7073) Add charset preamble to generated css
Closes #5884
Describe your changes:
Modifies the build process to prepend the generated theme CSS files with explicit UTF-8 encoding. In testing this seems to fix the mojibake issue.
All Submissions:
Author Checklist
Reviewer Checklist