Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchall for bug fix PRs and add performance category #7096

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Sep 27, 2023

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@shefalijoshi shefalijoshi requested a review from ozyx September 27, 2023 22:46
@deploysentinel
Copy link

deploysentinel bot commented Sep 27, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/29/2023 05:17:02pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: f57a900

Started: 09/29/2023 05:15:06pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 140 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/29/2023 05:17:02pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: f57a900

Started: 09/28/2023 04:01:40pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
1.61% (1) 1 / 62 run
failed over last 7 days
38.71% (24) 24 / 62 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 60 runs
failed over last 7 days
58.33% (35) 35 / 60 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
1.64% (1) 1 / 61 run
failed over last 7 days
72.13% (44) 44 / 61 runs
flaked over last 7 days

View Detailed Build Results


.github/release.yml Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #7096 (f57a900) into master (ab0e2d2) will decrease coverage by 4.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7096      +/-   ##
==========================================
- Coverage   59.89%   55.09%   -4.81%     
==========================================
  Files         412      649     +237     
  Lines       12792    26060   +13268     
  Branches        0     2547    +2547     
==========================================
+ Hits         7662    14357    +6695     
- Misses       5130    11013    +5883     
- Partials        0      690     +690     
Flag Coverage Δ *Carryforward flag
e2e-full 42.12% <ø> (ø) Carriedforward from ab0e2d2
e2e-stable 57.13% <ø> (-0.11%) ⬇️
unit 48.54% <ø> (?)

*This pull request uses carry forward flags. Click here to find out more.

see 383 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e2d2...f57a900. Read the comment docs.

@shefalijoshi shefalijoshi requested a review from ozyx September 28, 2023 15:59
@shefalijoshi shefalijoshi enabled auto-merge (squash) September 29, 2023 16:24
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 29, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 29, 2023
@shefalijoshi shefalijoshi merged commit 9f83381 into master Sep 29, 2023
6 of 8 checks passed
@shefalijoshi shefalijoshi deleted the fix-release-notes branch September 29, 2023 17:17
shefalijoshi added a commit that referenced this pull request Sep 29, 2023
…ory (#7096)

* Catchall for bug fix PRs and add performance category

* Move Bug fixes to the bottom

* Fix performance label
ozyx pushed a commit that referenced this pull request Sep 29, 2023
…gory (#7100)

cherry-pick(7096): Catchall for bug fix PRs and add performance category (#7096)

* Catchall for bug fix PRs and add performance category

* Move Bug fixes to the bottom

* Fix performance label
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants