-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit lines handle plot resizing #7151
Conversation
Current Playwright Test Results Summary✅ 163 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/30/2023 02:46:13pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 25 runsfailed over last 7 days |
20% (5)5 / 25 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 2 • Retry 1 • Initial Attempt |
0% (0)0 / 26 runsfailed over last 7 days |
26.92% (7)7 / 26 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0% (0)0 / 27 runsfailed over last 7 days |
25.93% (7)7 / 27 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
3.70% (1)1 / 27 runfailed over last 7 days |
59.26% (16)16 / 27 runsflaked over last 7 days |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7151 +/- ##
==========================================
+ Coverage 55.20% 55.28% +0.07%
==========================================
Files 672 672
Lines 26962 26969 +7
Branches 2620 2622 +2
==========================================
+ Hits 14884 14909 +25
+ Misses 11359 11341 -18
Partials 719 719
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…into redraw-limits-resize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just a few suggestions and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some e2e tests failing but otherwise LGTM
…s in openmct-yamcs.
@shefalijoshi Can we please resolve conflicts, and merge the test in openmct-yamcs? Thank you! |
@unlikelyzero Please approve. |
@shefalijoshi @unlikelyzero How do we get this merged? 😢 |
Discussed with @shefalijoshi and the highlighted test was moved to openmct-yamcs repo as requested.
Closes #6987
Describe your changes:
drawAPI.clear()
) before redrawing the chart and limit lines.All Submissions:
Author Checklist
Reviewer Checklist