Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit lines handle plot resizing #7151

Merged
merged 23 commits into from
Mar 5, 2024
Merged

Limit lines handle plot resizing #7151

merged 23 commits into from
Mar 5, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 19, 2023

Closes #6987

Describe your changes:

  1. Add a resize observer in charts for window resizing
  2. Ensure that the draw API height and width are reset (drawAPI.clear()) before redrawing the chart and limit lines.
  3. Noticed an error when unsubscribing to staleness - fixed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 19, 2023

Current Playwright Test Results Summary

✅ 163 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/30/2023 02:46:13pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: bbb91f2

Started: 11/30/2023 02:39:11pm UTC

⚠️ Flakes

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
0% (0) 0 / 25 runs
failed over last 7 days
20% (5) 5 / 25 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 2Retry 1Initial Attempt
0% (0) 0 / 26 runs
failed over last 7 days
26.92% (7) 7 / 26 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 27 runs
failed over last 7 days
25.93% (7) 7 / 27 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
3.70% (1) 1 / 27 run
failed over last 7 days
59.26% (16) 16 / 27 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 55.28%. Comparing base (eae5135) to head (23ee9a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7151      +/-   ##
==========================================
+ Coverage   55.20%   55.28%   +0.07%     
==========================================
  Files         672      672              
  Lines       26962    26969       +7     
  Branches     2620     2622       +2     
==========================================
+ Hits        14884    14909      +25     
+ Misses      11359    11341      -18     
  Partials      719      719              
Flag Coverage Δ
e2e-full 23.32% <ø> (ø)
e2e-stable 59.57% <ø> (+0.02%) ⬆️
unit 48.54% <10.52%> (+0.05%) ⬆️
Files Coverage Δ
src/plugins/plot/PlotView.vue 68.51% <ø> (-1.30%) ⬇️
src/plugins/plot/inspector/forms/SeriesForm.vue 31.74% <ø> (ø)
src/plugins/plot/stackedPlot/StackedPlotItem.vue 26.08% <16.66%> (-0.39%) ⬇️
src/plugins/plot/chart/MctChart.vue 46.59% <7.69%> (+3.58%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae5135...23ee9a6. Read the comment docs.

@shefalijoshi shefalijoshi requested a review from ozyx October 19, 2023 18:39
@ozyx ozyx added this to the Target:3.2.0 milestone Oct 20, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a few suggestions and comments.

src/plugins/plot/chart/MctChart.vue Outdated Show resolved Hide resolved
src/plugins/plot/chart/MctChart.vue Outdated Show resolved Hide resolved
src/plugins/plot/chart/MctChart.vue Outdated Show resolved Hide resolved
src/plugins/plot/chart/MctChart.vue Show resolved Hide resolved
src/plugins/plot/PlotView.vue Show resolved Hide resolved
src/plugins/plot/chart/MctChart.vue Outdated Show resolved Hide resolved
@shefalijoshi shefalijoshi requested a review from ozyx October 23, 2023 18:27
src/plugins/plot/chart/MctChart.vue Show resolved Hide resolved
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some e2e tests failing but otherwise LGTM

@unlikelyzero unlikelyzero modified the milestones: Target:3.2.1, Target:3.3.0 Nov 13, 2023
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
@davetsay davetsay added pr:e2e:flakefinder Runs the tests 10 times and removed pr:e2e:flakefinder Runs the tests 10 times labels Feb 1, 2024
@akhenry
Copy link
Contributor

akhenry commented Feb 5, 2024

@shefalijoshi Can we please resolve conflicts, and merge the test in openmct-yamcs? Thank you!

@shefalijoshi
Copy link
Contributor Author

@unlikelyzero Please approve.

@akhenry
Copy link
Contributor

akhenry commented Feb 26, 2024

@shefalijoshi @unlikelyzero How do we get this merged? 😢

@akhenry akhenry requested review from akhenry and removed request for ozyx and unlikelyzero March 4, 2024 22:00
@shefalijoshi shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 4, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 4, 2024
@shefalijoshi shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 5, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 5, 2024
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 5, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 5, 2024
@akhenry akhenry dismissed unlikelyzero’s stale review March 5, 2024 01:02

Discussed with @shefalijoshi and the highlighted test was moved to openmct-yamcs repo as requested.

@shefalijoshi shefalijoshi merged commit 0bdd096 into master Mar 5, 2024
37 checks passed
@shefalijoshi shefalijoshi deleted the redraw-limits-resize branch March 5, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Overlay Plots] Limit lines do not redraw when plot is resized
5 participants