Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set location hash if query parameters or path have changed #7306

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Dec 16, 2023

Closes #7303

Describe your changes:

Check to see if path or query parameters have changed, and change the hash accordingly. Previously we only altered the hash if the query parameters changed.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Dec 16, 2023 that may be closed by this pull request
7 tasks
Copy link

deploysentinel bot commented Dec 16, 2023

Current Playwright Test Results Summary

✅ 15 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/08/2024 07:27:28pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 9f8dd2d

Started: 01/08/2024 07:25:45pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 174 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/08/2024 07:27:28pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 9f8dd2d

Started: 01/08/2024 07:06:25pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
4.84% (3) 3 / 62 runs
failed over last 7 days
45.16% (28) 28 / 62 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
3.39% (2) 2 / 59 runs
failed over last 7 days
57.63% (34) 34 / 59 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.72% (1) 1 / 58 run
failed over last 7 days
56.90% (33) 33 / 58 runs
flaked over last 7 days

View Detailed Build Results


Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dfba4e2) 55.37% compared to head (9f8dd2d) 55.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7306      +/-   ##
==========================================
+ Coverage   55.37%   55.85%   +0.47%     
==========================================
  Files         657      657              
  Lines       26173    26180       +7     
  Branches     2546     2546              
==========================================
+ Hits        14494    14622     +128     
+ Misses      10976    10852     -124     
- Partials      703      706       +3     
Flag Coverage Δ *Carryforward flag
e2e-full 40.79% <ø> (-0.26%) ⬇️ Carriedforward from 817fb03
e2e-stable 59.00% <90.90%> (+1.16%) ⬆️
unit 48.87% <90.80%> (+0.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/MCT.js 96.96% <100.00%> (ø)
src/api/overlays/components/OverlayComponent.vue 75.00% <ø> (ø)
src/ui/layout/search/AnnotationSearchResult.vue 43.33% <ø> (ø)
src/ui/layout/search/ObjectSearchResult.vue 32.14% <100.00%> (ø)
src/ui/layout/search/SearchResultsDropDown.vue 76.47% <100.00%> (ø)
src/ui/preview/PreviewContainer.vue 27.50% <ø> (ø)
src/ui/router/ApplicationRouter.js 87.62% <100.00%> (+1.60%) ⬆️
src/plugins/clock/components/ClockComponent.vue 77.77% <33.33%> (ø)
src/ui/router/Browse.js 93.33% <92.64%> (+1.66%) ⬆️

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfba4e2...9f8dd2d. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 16, 2023
@scottbell scottbell marked this pull request as ready for review December 16, 2023 15:23
@scottbell scottbell requested review from ozyx and davetsay December 16, 2023 15:23
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 16, 2023
@scottbell scottbell changed the title Set hash if param or path have changed Set location hash if query parameters or path have changed Dec 17, 2023
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @scottbell , and quickly turned around.

One ask. If you are going through the trouble of refactoring Browse, can you also take it one step further and export Browse as an es6 module?

@scottbell scottbell requested a review from davetsay December 19, 2023 10:41
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 19, 2023
@ozyx ozyx added the type:bug label Dec 22, 2023
@ozyx ozyx added this to the Target:3.3.0 milestone Dec 22, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 8, 2024
@scottbell scottbell merged commit 64d4ddd into master Jan 8, 2024
21 checks passed
@scottbell scottbell deleted the 7303-url-not-updating-when-navigating-to-object-from-grand-search branch January 8, 2024 19:29
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL not updating when navigating to object from Grand Search
4 participants