-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set location hash if query parameters or path have changed #7306
Set location hash if query parameters or path have changed #7306
Conversation
…ng-when-navigating-to-object-from-grand-search
Current Playwright Test Results Summary✅ 15 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/08/2024 07:27:28pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 9f8dd2d Started: 01/08/2024 07:25:45pm UTC Current Playwright Test Results Summary✅ 174 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 01/08/2024 07:27:28pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
4.84% (3)3 / 62 runsfailed over last 7 days |
45.16% (28)28 / 62 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
3.39% (2)2 / 59 runsfailed over last 7 days |
57.63% (34)34 / 59 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
1.72% (1)1 / 58 runfailed over last 7 days |
56.90% (33)33 / 58 runsflaked over last 7 days |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7306 +/- ##
==========================================
+ Coverage 55.37% 55.85% +0.47%
==========================================
Files 657 657
Lines 26173 26180 +7
Branches 2546 2546
==========================================
+ Hits 14494 14622 +128
+ Misses 10976 10852 -124
- Partials 703 706 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic @scottbell , and quickly turned around.
One ask. If you are going through the trouble of refactoring Browse, can you also take it one step further and export Browse as an es6 module?
…bject-from-grand-search
…bject-from-grand-search
…bject-from-grand-search
…bject-from-grand-search
…bject-from-grand-search
…bject-from-grand-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…bject-from-grand-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7303
Describe your changes:
Check to see if path or query parameters have changed, and change the hash accordingly. Previously we only altered the hash if the query parameters changed.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist