Provide renderWhenVisible to LadTableSets
#7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
scottbell
changed the title
renderWhenVisible to LadTableSets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7384 +/- ##
==========================================
+ Coverage 55.89% 55.91% +0.02%
==========================================
Files 659 659
Lines 26278 26277 -1
Branches 2550 2549 -1
==========================================
+ Hits 14687 14692 +5
+ Misses 10882 10877 -5
+ Partials 709 708 -1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This comment was marked as resolved.
This comment was marked as resolved.
7 tasks
scottbell
deleted the
7383-lad-table-sets-failing-to-initialize-telemetry
branch
| @@ -36,7 +36,7 @@ test.describe('Testing numeric data with inspector data visualization (i.e., dat | |||
| await page.goto('./', { waitUntil: 'domcontentloaded' }); | |||
| }); | |||
|
|
|||
| test('Can click on telemetry and see data in inspector', async ({ page }) => { | |||
| test('Can click on telemetry and see data in inspector', async ({ page, context }) => { | |||
There was a problem hiding this comment.
this should have had a @2p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7383 #7382
Describe your changes:
renderWhenVisibleto LadTableSets (and thus to child LadTables)ladTelemetryObjectsis actually initialized before adding objects to itAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist