d3 implementation of progress pie chart #7485
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7485 +/- ##
==========================================
+ Coverage 55.24% 55.28% +0.03%
==========================================
Files 672 673 +1
Lines 26965 26994 +29
Branches 2622 2623 +1
==========================================
+ Hits 14898 14924 +26
- Misses 11346 11351 +5
+ Partials 721 719 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
The pie isn't displaying properly at 0% (yellow arrow) and 100% (orange arrow).
- At 0%, it's displaying a very thin sliver of progress, but shouldn't.
- At 100%, it's displaying a very thin sliver of "incompleteness", but shouldn't.
This may be due to not "rounding" things properly; I had to deal with this in the previous code when progress was near 100%: if the amount of remaining update (in terms of percent) was less than the percent-update-per-tick, my version was always stalling and never getting to 100%. I added a test to check if the remaining percent < the percent-update-per-tick, and if so, directly set the percentage to 100%.
Maybe there's a related thing near 0?
0% works now: Screen.Recording.2024-02-12.at.10.14.11.AM.movand so does 100%: Screen.Recording.2024-02-12.at.10.16.40.AM.mov |
|
This is ready to ship! My name is @charlesh88 and I approve this message. |
|
let's make sure we have coverage |
…t least one clock tick. Write tests for progress pie
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
e2e/constants.js
Outdated
| @@ -17,3 +17,9 @@ export const MISSION_TIME = 1732413600000; // Saturday, November 23, 2024 6:00:0 | |||
| */ | |||
| export const VISUAL_URL = | |||
| './#/browse/mine?tc.mode=fixed&tc.startBound=1693592063607&tc.endBound=1693593893607&tc.timeSystem=utc&view=grid&hideInspector=true&hideTree=true'; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
@shefalijoshi can you update this?
Closes #7377 #7483
Describe your changes:
Use the d3.arc API to draw pie progress
-driveby to fix some of the flaky percy tests
-driveby to add a mission percy test
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist