-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this is 2024. *
observers no more.
#7715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7715 +/- ##
==========================================
+ Coverage 56.38% 56.50% +0.11%
==========================================
Files 673 673
Lines 27185 27181 -4
Branches 2635 2635
==========================================
+ Hits 15329 15359 +30
+ Misses 11526 11492 -34
Partials 330 330
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. I've left some suggestions for improving test locators and labels
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
Outdated
Show resolved
Hide resolved
…c.js Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
…c.js Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
…c.js Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
…c.js Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work
Closes #7710
Describe your changes:
Removed the
*
observer since the mutable domain object doesn't need itAll Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist