VxWorks OSAL uses potentially unsafe "strcpy" operations

[skliper]

In at several locations the VxWorks OSAL is using strcat() and strcpy() functions to copy strings between string buffers that are sized using different macros.

At least one of the sizes in play, the OS_MAX_PATH_LEN comes from the user-configurable "osconfig.h" file. Other sizes, such as OS_FS_PHYS_NAME_LEN are specified in the local headers and are not user-configurable.

In some functions, such as OS_mkfs (but not limited to this), a local buffer of size OS_MAX_PATH_LEN is copied into a global buffer of size OS_FS_PHYS_NAME_LEN.

However, because the OS_MAX_PATH_LEN is configurable via the osconfig.h file, it is not guaranteed that OS_MAX_PATH_LEN is less than or equal to OS_FS_PHYS_NAME_LEN.

[skliper]

Imported from trac issue 172. Created by jphickey on 2016-07-26T17:07:26, last modified: 2019-08-14T14:11:46

[skliper]

Trac comment by jphickey on 2019-03-26 08:52:42:

This can be added to the pool of "stuff that gets fixed by migrating to NG architecture". After #231 gets merged this should be closed.

[skliper]

Just needs close review to confirm all cases were addressed.

[skliper]

Only remaining concern:

os/shared/osapi-printf.c: strcpy(console->device_name, OS_PRINTF_CONSOLE_NAME);

Could be defined in osconfig.h, but no check on size seen (quick inspection).

[skliper]

Want me to reassign this one? @jphickey

[jphickey]

No, I'll just change that last case to an strncpy instead, as part of the other refactoring I am doing for #285. Any change made separately will likely cause merge woes.

Note that the symbol OS_PRINTF_CONSOLE_NAME would be defined in osconfig.h, which the same file as OS_MAX_API_NAME (the actual length limit) is defined. But it doesn't hurt to use strncpy instead of strcpy here just in case the user misconfigures, and its a trivial change in the code.

[skliper]

Closed in #443