-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine "pc-linux" and "pc-linux-ut" OSAL BSPs #81
Comments
Imported from trac issue 58. Created by jphickey on 2015-06-17T10:58:59, last modified: 2015-11-20T16:22:16 |
Trac comment by jphickey on 2015-06-17 11:02:09: This was originally done as part of #40, but cherry-picking this modification out of that change set since it is required to make unit tests work in the current integration candidate ({{{ic-2015-0616}}} branch). |
Trac comment by jphickey on 2015-06-17 17:51:01: Pushed [changeset:7f36448] for review. This is also merged into the {{{ic-2015-0616}}} branch and the unit tests build/run successfully as part for that merge. |
Trac comment by jwilmot on 2015-06-30 10:51:40: It makes sense to have only one BSP if possible. Recommend accept. |
Trac comment by glimes on 2015-06-30 10:56:58: Recommend accept. From a design standpoint, I like this change as it NB: I did have to go look at the real source for |
Trac comment by acudmore on 2015-06-30 12:29:37: recommend accept |
Trac comment by glimes on 2015-06-30 14:45:40: CCB approved. |
There is a separate BSP called {{{pc-linux-ut}}} that is used for unit testing. This differs slightly from the normal {{{pc-linux}}} BSP:
Having a different BSP violates the "fly what you test, test what you fly" philosophy.
The unit tests driven by timers do not work with signals blocked, because these rely on signals working during {{{OS_Application_Startup()}}} in order to function. This is probably the reason for the alternate BSP.
However, these tests can and should be fixed to operate using the normal BSP with signals blocked, as this will be more representative of what happens in a normal system. To fix these tests just requires creating a child thread to handle the test logic and allowing {{{OS_Application_Startup}}} to complete normally.
The text was updated successfully, but these errors were encountered: