Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to OSAL UT stub code in osapi_stubs #93

Closed
skliper opened this issue Sep 30, 2019 · 11 comments
Closed

Enhancements to OSAL UT stub code in osapi_stubs #93

skliper opened this issue Sep 30, 2019 · 11 comments
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

This ticket reflects further testing with CFE unit tests. Previous ticket #40 is now integrated with CFE unit tests but some additional bits are needed to make everything right. Since #40 was approved at the last CCB, it is not going to be amended anymore, so this is a follow-on update.

  • Hooks were not completely implemented - CFE needs this to make the latest version fully testable.
  • Provide stubs for missing functions: {{{OS_TimerCreate}}}, {{{OS_TimerAdd}}}, {{{OS_TimerSet}}}, {{{OS_CountSemCreate}}}.
@skliper skliper added this to the osal-4.2 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 70. Created by jphickey on 2015-07-02T13:31:38, last modified: 2015-11-20T16:22:16

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-07-02 14:43:52:

Pushed commit [changeset:1f5c968] for review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-07-09 14:52:53:

Note - the above commit is merged into the {{{ic-2015-07-14}}} integration candidate branch for testing. Since the rest of the unit testing framework is already included, it makes sense that this be merged in as well.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-07-10 12:53:02:

Additional commit pushed which adds more stubs for timebase API functions {{{OS_TimeBaseCreate}}}, {{{OS_TimeBaseDelete}}}, etc.

Commit [changeset:3bb3ee4]

Also added to the {{{ic-2015-07-14}}} merge

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by acudmore on 2015-07-10 15:05:47:

recommend accept

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-07-13 14:13:41:

Accept.

It looks like this was rebased and changeset [changeset:1f5c968] is actually
carrying the modification.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-07-13 14:17:04:

Replying to [comment:6 glimes]:

Accept.

It looks like this was rebased and changeset [changeset:1f5c968] is actually
carrying the modification.

Actually the ones in [changeset:1f5c968] are a different set of stubs. There are two commits adding a different set of stubs, I kept them separate just in case anyone had already looked at the first diff.

After merging both of these change sets we should have a stub for every currently defined OSAL function.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-07-13 19:17:11:

Ah, I see it now. Slight tool reorg was needed ;)

Yep, Accept [changeset:3bb3ee4].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by sduran on 2015-07-14 12:21:19:

accept

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jwilmot on 2015-07-14 12:36:10:

Recommend accept.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-07-16 10:35:28:

Included in [changeset:ec67bd4 2015-07-14 development merge],
now present on Babelfish and IPAS-LIB.

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant