Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_app should have a clearly-defined "publish telemetry" function #39

Open
CDKnightNASA opened this issue Feb 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@CDKnightNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd venture most folks who look at the sample_app code are looking to read some data from a sensor/instrument and publish the telemetry onto the software bus. The current code does not make it clear where such code would go...I'd venture it'd go in "ProcessCC()"? In fact, the only call to CFE_SB_SendMsg() is in ReportHousekeeping() function.

Describe the solution you'd like
The Sample App demonstrates reading from a table and calling a library, perhaps a call to a library function that iterates through an array (provided by a table) of values and publishes the next one on each command received?

Needless to say, a big comment block stating "add your code here" would be appropriate. The ProcessCC() function really has no documentation in the comments as to what it does.

Describe alternatives you've considered
I think some folks on the CCB consider the sample app to not be a skeleton for a real application. If that is the intent, it should be made more clear in the sample_app.c file and the README.md, and it would be appropriate to have a separate skeleton app for folks to start developing from. (In fact, such a skeleton would be a nice source for developers to fork from, and any major framework changes could be made in the skeleton and folks would see the change when they fetch from their upstreams.)

Additional context
Add any other context about the feature request here.

Requester Info
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA self-assigned this Feb 10, 2020
@skliper skliper added the enhancement New feature or request label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants