Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #121, Remove registration of empty EVS filters #122

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jun 14, 2022

Describe the contribution

Testing performed
CI

Expected behavior changes
None, just removes empty filter registration

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 14, 2022
@skliper skliper added this to the Draco milestone Jun 14, 2022
*/
CFE_EVS_Register(CFE_TO_EVS_Filters, sizeof(CFE_TO_EVS_Filters) / sizeof(CFE_EVS_BinFilter_t),
CFE_EVS_EventFilter_BINARY);
CFE_EVS_Register(NULL, 0, CFE_EVS_EventFilter_BINARY);

Check warning

Code scanning / CodeQL

Unchecked return value

The return value of non-void function [CFE_EVS_Register](1) is not checked.
@astrogeco
Copy link
Contributor

CCB:2022-06-08 APPROVED

@astrogeco astrogeco added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 17, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 20, 2022
nasa/to_lab#122, Remove registration of empty EVS filters
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 21, 2022
nasa/to_lab#122, Remove registration of empty EVS filters
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 22, 2022
*Combines:*

cFE  v7.0.0-rc4+dev143
osal osal v6.0.0-rc4+dev87
psp v1.6.0-rc4+dev

ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev21
sample_app v1.3.0-rc4+dev21

**Includes:**

- nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning
- nasa/cFE#2115, Add macro for initializing command header

*Add StatusToString API*
- nasa/osal#1259, Add OS_StatusToString API
- nasa/PSP#347, Add CFE_PSP_StatusToString and CFE_PSP_STATUS_C
- nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C

*Remove registration of empty EVS filters*
- nasa/ci_lab#111, Remove registration of empty EVS filters
- nasa/to_lab#122, Remove registration of empty EVS filters
- nasa/sample_app#175, Remove registration of empty event filters
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 22, 2022
*Combines:*

cFE  v7.0.0-rc4+dev143
osal osal v6.0.0-rc4+dev87
psp v1.6.0-rc4+dev

ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev21
sample_app v1.3.0-rc4+dev21

**Includes:**

- nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning
- nasa/cFE#2115, Add macro for initializing command header

*Add StatusToString API*
- nasa/osal#1259, Add OS_StatusToString API
- nasa/PSP#347, Add CFE_PSP_StatusToString and CFE_PSP_STATUS_C
- nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C

*Remove registration of empty EVS filters*
- nasa/ci_lab#111, Remove registration of empty EVS filters
- nasa/to_lab#122, Remove registration of empty EVS filters
- nasa/sample_app#175, Remove registration of empty event filters

Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
@astrogeco astrogeco merged commit baa9988 into nasa:main Jun 22, 2022
@skliper skliper deleted the fix121-rm_empty_filters branch September 19, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration of events with 0x0000 filters isn't all that helpful
2 participants