Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose strahler stream network in delineateit #884

Closed
phargogh opened this issue Feb 8, 2022 · 2 comments · Fixed by #1291
Closed

Expose strahler stream network in delineateit #884

phargogh opened this issue Feb 8, 2022 · 2 comments · Fixed by #1291
Assignees
Labels
enhancement New feature or request in progress This issue is actively being worked on
Milestone

Comments

@phargogh
Copy link
Member

phargogh commented Feb 8, 2022

Rafa just stopped by to request if we could add a stream network creation step to DelineateIt, since it would be useful for a couple of upcoming projects. Rich had added a Strahler Stream Network delineation function to pygeoprocessing, and Rafa says that this is sufficient for what he's thinking about.

The definition of what it means to be a "stream" gets a little murky for MFD, so since DelineateIt allows both D8 and MFD, this optional output of DelineateIt would only be available if the user has selected D8 routing.

@phargogh phargogh added the enhancement New feature or request label Feb 8, 2022
@phargogh phargogh added this to the 3.10.3 milestone Feb 8, 2022
@phargogh
Copy link
Member Author

Let's bump this to a future release.

Explaining the various statistical inputs to this so that we don't potentially get a bunch of forums questions about it will take a little time that I don't have right now and I don't think this should hold up the release.

I've started working on this a little bit on my InVEST fork: https://github.com/phargogh/invest/tree/feature/349-expose-subwatershed-delineation-and-strahler-streams. Subwatershed delineation has not yet been added.

One other thing is that this branch is adding these changes to RouteDEM rather than DelineateIt. The reason for this is that DelineateIt is clearly focused around delineating watersheds by user-provided outflow features. By contrast, RouteDEM seems a more natural home for this because everything within RouteDEM is derived from the complete landscape, plus slope (which isn't strictly routing) so it's a bit more of a hodgepodge of routing-related functions.

@phargogh phargogh modified the milestones: 3.11.0, 3.12 May 10, 2022
@dcdenu4 dcdenu4 modified the milestones: 3.12, 3.12.1 Aug 19, 2022
@phargogh phargogh modified the milestones: 3.12.1, 3.12.2 Dec 9, 2022
@phargogh phargogh modified the milestones: 3.12.2, 3.13.0 Jan 20, 2023
@phargogh phargogh modified the milestones: 3.13.0, 3.13.1 Mar 3, 2023
@phargogh
Copy link
Member Author

phargogh commented May 2, 2023

This work is being done as a part of #349

@phargogh phargogh added the in progress This issue is actively being worked on label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress This issue is actively being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants