-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"npm audit" reports electron-settings as a high security vulnerability #179
Comments
Hey, |
Thanks a lot for already creating the Pull-Request! 👍 I hope it gets merged and pushed through as a new Release soon, as this security issues currently pops up as a very red flag also in our electron projects :/ |
4.0.3 is live. Please give it a try and let me know if it's working as expected. |
It looks like everything is working as expected for me, thank you! |
After regenerating our Lockfile which made everything use the new version and remove the old lodash packages, everything seems fine again. Thanks for your fast reaction :) |
When making an app using electron 28.2.3 or later, including electron-settings 4.0.2 or 5.0.0 as a dependency causes this output when running
npm install
ornpm audit
:This workaround, which forces npm to override old versions of lodash.set in package.json...
...does not work as it prevents any settings from being written.
The text was updated successfully, but these errors were encountered: