Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display nations in alphabetical order #154

Open
RobertMartinis opened this issue May 26, 2021 · 4 comments
Open

Display nations in alphabetical order #154

RobertMartinis opened this issue May 26, 2021 · 4 comments
Labels
bug Something isn't working nations Regards the nations page settings Regards the settings

Comments

@RobertMartinis
Copy link
Contributor

Currently, the order nations are listed in the nations page and notifications settings page seems random, it would be good if they were ordered alphabetically.

@RobertMartinis RobertMartinis added bug Something isn't working settings Regards the settings nations Regards the nations page labels May 26, 2021
@Frewacom
Copy link
Member

Agreed

@johanneslil
Copy link
Member

johanneslil commented Jun 13, 2021

Should they perhaps be ordered alphabetically on the server side? So that they don't have to be sorted over and over on the front-end. Or is there a reason not to do it that way? @McFrappe

@McFrappe
Copy link
Member

McFrappe commented Jun 13, 2021

I'll fix.

@RobertMartinis
Copy link
Contributor Author

RobertMartinis commented Jun 13, 2021

I'll fix.

https://github.com/nationskollen/server/blob/5f10828a0f1dffcfc495838eda2872db7cbe017d/database/seeders/Nation.ts#L39-L62
Lowest alphabethical mapped to the lowest oid should fix the issue, if it doesn't break something else in the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nations Regards the nations page settings Regards the settings
Projects
None yet
Development

No branches or pull requests

4 participants