Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the notification settings dropdown #164

Open
Frewacom opened this issue May 26, 2021 · 0 comments
Open

Consider removing the notification settings dropdown #164

Frewacom opened this issue May 26, 2021 · 0 comments
Labels
design enhancement New feature or request notifications settings Regards the settings

Comments

@Frewacom
Copy link
Member

Instead of having a dropdown with nested toggles, we can just have a dropdown with values that allows us to select which type(s) of notifications we want. E.g. just like a <select> element.

You can have the following options:

  • None
  • News
  • Events
  • All

The upside of doing this is that the logic for rendering the component will be much easier. Currently, if you toggle the dropdown, the toggles will lose their state and it is just a pain to work with. With a single dropdown with values, the components will always stay rendered and will therefore keep their state while the screen is open/cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request notifications settings Regards the settings
Projects
None yet
Development

No branches or pull requests

1 participant