Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teach xform to scale neuron diameter when appropriate #387

Open
jefferis opened this issue Feb 19, 2019 · 5 comments
Open

teach xform to scale neuron diameter when appropriate #387

jefferis opened this issue Feb 19, 2019 · 5 comments

Comments

@jefferis
Copy link
Collaborator

Although neurons can easily be scaled with both points/radius information xform and friends (e.g. xform_brain currently can only transform point locations.

@jefferis
Copy link
Collaborator Author

My first thought was that including a function in a reglist object would solve this. But that doesn't work because xform eventually hands off to xformpoints and that only deals with 3D point information.

@jefferis
Copy link
Collaborator Author

My next thought was to provide a specialised xform.neuron method and to have that intercept the case when reg is a function (see 2993a4b). That sort of works, but fails when reg is actually a reglist object (one of whose elements is a function).

@jefferis
Copy link
Collaborator Author

Adding further specialised logic to xform.neuron to handle reglist type registrations by peeking inside them feels very inelegant.

@jefferis
Copy link
Collaborator Author

Perhaps one could add xformneuron.reglist and have that sort out the logic applying transforms. But that's actually pretty close to what I just mentioned and would largely duplicate xformpoints.reglist.

@jefferis
Copy link
Collaborator Author

Maybe we need a different class of transform that signals that it can be applied to Nx4 points and will scale diameters accordingly. But that still implies that we need some logic to inspect a reglist and decide what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant