-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for potential false-positives #1
Comments
I'm noticing quite a few false positives using babel w/ async await. I think it detects awaiting a function as blocking the loop, not 100% sure. |
Interesting... async await should be handled internally by the same hook implementation as promises. |
Hey @naugtur. I'm noticing a few false positives when I'm using Promises. |
I'm looking forward to gists with examples or failing testcase contributions. My daughter is born in ~2 weeks and my opensource time budget won't allow tracking this down on my own. |
Pushed v1.1.0 where I introduced a simple countermeasure for false positives. Please check if you see a change in behavior when toggling |
This library is not exactly what async hooks were designed for. While it's working for a few cases I investigated, there might be some edge cases out there. The worst case scenario being a false positive, where it'd report a function that's not blocking the event loop.
This needs some investigation.
If you're using this library, feel free to discuss examples of functions it detected.
The text was updated successfully, but these errors were encountered: