Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check browser support on SpinViewer #39

Closed
jongmoon opened this issue Oct 26, 2017 · 5 comments
Closed

Check browser support on SpinViewer #39

jongmoon opened this issue Oct 26, 2017 · 5 comments
Assignees
Labels
🔄 SpinViewer (v3) Issues related to SpinViewer (View360 v3)

Comments

@jongmoon
Copy link

Description

It's difficult to check if spinviewer is available. It's better to give a chance to check available. for example firing exception.

@jongmoon jongmoon added 🔄 SpinViewer (v3) Issues related to SpinViewer (View360 v3) enhancement labels Oct 26, 2017
@jongmoon
Copy link
Author

jongmoon commented Oct 30, 2017

  1. Need feature detection for background-size style.
  • for example, Android 4.3 does not support background-size.
    image
  1. IE version must be larger than 8

@jongmoon jongmoon self-assigned this Oct 30, 2017
@jongmoon
Copy link
Author

jongmoon commented Oct 30, 2017

Feature Tested

  • Galaxy S2 2.3.6, Default Browser
    • background-size feature: true
    • working: true
      • But It needs es5-shim files to makes axes work!
<script src="https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.5/es5-shim.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.5/es5-sham.js"></script>
  • Galaxy S3 4.0.4 , Default Browser
    • true
    • true
  • Galaxy S4 4.2.2 , Default Browser
    • true
    • true
  • Windows 7, IE8
    • false
    • false
  • Galaxy S6 5.0.2, Default Browser
    • Mozilla/5.0 (Linux;Android 5.0.2;SAMSUNG SM-G920S Build/LRX22G) AppleWebkit/537.36(KHTML, like Gecko) SamsungBrowser/3.0 Chrome/38.0.2125.102 Mobile Safari/537.36
    • true
    • true
  • Galaxy A8 5.1.1, Default Browser (4.0)
    • image
    • true
    • true
  • Galaxy S6 Edge 5.0.2, Default Browser <-- Issue
    • Mozilla/5.0 (Linux;Android 5.0.2;SAMSUNG SM-G925S Build/LRX22G) AppleWebkit/537.36(KHTML, like Gecko) SamsungBrowser/3.0 Chrome/38.0.2125.102 Mobile Safari/537.36
    • true
    • false <-- not working

@jongmoon
Copy link
Author

jongmoon commented Oct 31, 2017

It's related with pixel of jpeg image on Galaxy S6 Edge (Default Browser 3.0).

To tell the conclusion first,

  • If image is jpeg
  • and image pixel is more than 3.7 megapixels (3,686,760)

Samsung Browser 3 (on S6 Edge - SM-G925S) cannot calculate size of image.

I tested following cases.

  • 640 x 15360 (X) - it was first image that I found odd action.
  • 630 x 15120 (X) - resize above original image
  • 500 x 12000 (x)
  • 400 x 9600 (x)
  • 320 x 7680 (o)
  • 333 x 8000 (o)
  • 375 x 9000 (o)
  • 388 x 9300 (o)
  • 394 x 9450 (x)
  • 391 x 9375 (x)
  • 393 × 9425 (x)
  • 392 × 9412 (x)
  • 392 × 9406 (x)
  • 392 × 9403 (o)
  • 392 × 9404 (o)
  • 392 × 9405 (o) <-- Max size that works OK
  • 15360 × 640 (x) <-- rotate 90',
  • 1280 × 7680 (x) <-- width * 2, height / 2
  • 780 × 4680 (o) <-- resize above. it works OK
  • 785 × 4710 (x)
  • 640 x 15360 (o) PNG converted

@jongmoon
Copy link
Author

I think it is not proper to limit that browser because it can be used other case on that browser.

So let's make documentation for this issue.

@jongmoon
Copy link
Author

jongmoon commented Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 SpinViewer (v3) Issues related to SpinViewer (View360 v3)
Projects
None yet
Development

No branches or pull requests

1 participant