Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eg.visible not working with first Element param #146

Closed
happyhj opened this issue Feb 29, 2016 · 1 comment
Closed

eg.visible not working with first Element param #146

happyhj opened this issue Feb 29, 2016 · 1 comment
Assignees
Milestone

Comments

@happyhj
Copy link
Contributor

happyhj commented Feb 29, 2016

Description

eg.visible is not working property when the first parameter is Element.
When the first parameter is document, it works well

Steps to check or reproduce

var visibleView = new eg.Visible($("#content"), { ...

Element as wrapper demo <--- not working
document as wrapper demo <--- working

@mixed mixed modified the milestone: 1.2.0 Mar 24, 2016
@happyhj
Copy link
Contributor Author

happyhj commented May 26, 2016

The first parameter of eg.Visible() is container of scrollerable child elements that overflow parent element.

So demo on the first link is working properly. Because container $("#content") does not have fixed height so children of the container cannot overflow.

Visibility at eg.Visible is not related with browser's viewport except when the first parameter is document.

@happyhj happyhj closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants