Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make path to ktlint-executable configurable instead of using a bundled ktlint-version #241

Closed
ajans opened this issue Oct 28, 2022 · 1 comment

Comments

@ajans
Copy link

ajans commented Oct 28, 2022

Thank you for this great plugin!

The thing that would make my (and maybe your) life easier, would be to set the path to the ktlint-executable used by this plugin (similar to how the Git-executable is configured in Android Studio et al).

As it is now, the plugin-bundled version of ktlint is 0.46.1 according to the changelog on the plugin-homepage.
The latest released official version of ktlint from pinterest is 0.47.1.

Right now I cannot be sure that the latest ktlint-version used by CI and local proxy-installation is reporting / fixing the same issues as the plugin-bundled version.

By using a separate installation of ktlint would enable me to use the same version of ktlint everywhere.

For you as the plugin-author this enhancement would lift the burden of updating the plugin for every new ktlint-version from you.

I understand there may be issues parsing the ktlint-output with an unknown plugin-external ktlint-installation as incompatible changes in the report-format might break the plugin.
If that is the case/concern, then feel free to close this issue as a wontfix (in that case could you please update the plugin to use the latest ktlint-version?).

Thank you for your support!

@nbadal
Copy link
Owner

nbadal commented Nov 18, 2022

Would definitely love to support multiple versions of ktlint - I believe this is essentially a duplicate of #35 though! Let's use that ticket for related discussion

@nbadal nbadal closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants