Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script creates binary by invalid name. #2

Closed
nbering opened this issue Jan 21, 2018 · 4 comments
Closed

Release script creates binary by invalid name. #2

nbering opened this issue Jan 21, 2018 · 4 comments

Comments

@nbering
Copy link
Owner

nbering commented Jan 21, 2018

The plugin filename convention was inaccurately documented by Terraform, so the "helpful" file name I used for the release binary filenames is incorrect. The dash(-) between the plugin name and the version number should be an underscore(_).

hashicorp/terraform#15705

@imchairmanm
Copy link

Thanks for opening this! I had a bit of trouble trying to figure out why Terraform was unable to find the plugin. I didn't think to look at the binary name.

Also, just wanted to say that this approach has been working really well for me. Thank you for providing the tools and for writing up the blog post on them!

@nbering
Copy link
Owner Author

nbering commented Feb 12, 2018

Thanks @imchairmanm! There's a fair bit of traffic coming to the blog post and Repo. I have a little vacation time coming up, so I may do some further clean-up and documentation while I have the time.

Clearing up this issue would be included in that effort.

@nbering
Copy link
Owner Author

nbering commented Feb 25, 2018

Re-opening until I get a new release builds attached to the GitHub release.

@nbering nbering reopened this Feb 25, 2018
@nbering
Copy link
Owner Author

nbering commented Feb 25, 2018

Closing again... should be fixed in archives attached to v0.0.2.

v0.0.2 is functionally equivalent to v0.0.1, except that the release build process has been improved.

@nbering nbering closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants