Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request upgrade to Android X #161

Closed
tcqq opened this issue Aug 5, 2018 · 10 comments
Closed

Request upgrade to Android X #161

tcqq opened this issue Aug 5, 2018 · 10 comments

Comments

@tcqq
Copy link

tcqq commented Aug 5, 2018

@ncapdevi Request to upgrade FragNav to Android X

Because the support library and the androidx library are incompatible, This will lead to multiple errors.
Because support is about to be replaced by androidx.
image
image

Refactor AndroidX URL:

https://android-developers.googleblog.com/2018/05/hello-world-androidx.html
https://developer.android.com/studio/preview/features/#androidx_refactoring
https://dl.google.com/dl/android/maven2/index.html

image

@diareuse
Copy link

diareuse commented Aug 6, 2018

You're welcome to create pull request for this.
It's simple, you fork this repository. Make changes and then create pull request with your changes. They may not be accepted by the repository owner. However looking at the history of pull requests, it's generally very likely to be accepted.

Have a great day.

@tcqq
Copy link
Author

tcqq commented Aug 6, 2018

@diareuse Thank you for your reply, I will try it when I have time.

@mateherber
Copy link
Contributor

If you use the android.enableJetifier = true flag in your project gradle plugin will automagically convert all the libraries you use as if it were written for androidX even if the library hasn't yet been migrated.

image

@diareuse
Copy link

diareuse commented Aug 9, 2018

@mateherber this is true, however as of now it's done in build time, which could significantly increase the total build time. That's why I suspect he's requesting that transition

@mateherber
Copy link
Contributor

I'm not sure about the added build time there but I'd wait for migrating any library (at least the release part) until androidX is final

@diareuse
Copy link

diareuse commented Aug 9, 2018

That's for sure, +1 for that.

@ShurikuS57
Copy link

AndroidX is final.

@JoeKaldas
Copy link

So is there a build that supports androidx?

@mateherber
Copy link
Contributor

Please watch #178

@ncapdevi
Copy link
Owner

#187 will be released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants