Trigger transaction listener when restoring tab from bundle #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FragNavController.restoreFromBundle` attempts to re-select the previously selected tab when restoring its state from a `Bundle`, but was not notifying the `TransactionListener` (if one was set).
|
@ncapdevi Let me know if there's more to it than this - not sure if I need to modify any tests or anything |
|
@ncapdevi It'd be great to get this merged and pulled into my fork - let me know if you need me to add anything else in the PR |
|
@erawhctim apologies for delay, building a release now |
|
Awesome! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FragNavController.restoreFromBundleattempts to re-select thepreviously selected tab when restoring its state from a
Bundle, butwas not notifying the
TransactionListener(if one was set).