Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire unused code related to using the Annotator with the batch endpoint #264

Open
jvendetti opened this issue May 16, 2023 · 1 comment
Assignees

Comments

@jvendetti
Copy link
Member

Clicks on the "Get Annotations" button on the Annotator page are handled by the get_annotations JS function. There's a line in the function that sets the "raw" parameter to always be true:

// UI checkbox to control using the batch call in the controller.
params.raw = true; // do not use batch call to resolve class prefLabel and ontology names.

The comments appear to indicate that using the /batch endpoint to resolve class preferred labels and ontology names was disabled. I dug around in the commit history and found said checkbox was removed 8 years ago in this commit.

The end result is that we have some unreachable methods in the AnnotatorController, including:

massage_annotated_classes

get_annotated_classes

simplify_annotated_classes

... and one in the ApplicationController:

get_batch_results

For testing purposes, I set the "raw" parameter to false in my local dev environment. The methods referred to above no longer work - a simple action like inserting our sample text and attempting to fetch annotations results in a 200 OK status, but the page reports no annotations found. The expected result with our sample text is that annotations are returned and displayed.

@jvendetti jvendetti self-assigned this May 16, 2023
@jonquet
Copy link

jonquet commented May 16, 2023

No idea what it is. Maybe something fora more efficient (batch) lookup in the Redis storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants