Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Spearman rank correlation #313

Open
nicholasloveday opened this issue May 10, 2024 · 5 comments · May be fixed by #773
Open

Request: Spearman rank correlation #313

nicholasloveday opened this issue May 10, 2024 · 5 comments · May be fixed by #773
Labels
good first issue Good for newcomers new metric Adding a new metric or score
Milestone

Comments

@nicholasloveday
Copy link
Collaborator

@BethEbert requested that we add Spearman rank correlation in #309

It should be straightforward to create using xr.cov and xr.std

@nicholasloveday nicholasloveday added this to the Wishlist milestone May 10, 2024
@tennlee tennlee changed the title Spearman rank correlation Request: Spearman rank correlation Nov 2, 2024
@tennlee tennlee added new metric Adding a new metric or score good first issue Good for newcomers labels Nov 22, 2024
@lbluett
Copy link
Contributor

lbluett commented Nov 25, 2024

I will work on this one

@Steph-Chong
Copy link
Collaborator

@lbluett just a heads up that over time scores has refined what we include in docstrings.

Here are some links to some recently written docstrings, which can serve as guides/templates:

KGE: https://scores.readthedocs.io/en/stable/api.html#scores.continuous.kge
Interval Score: https://scores.readthedocs.io/en/stable/api.html#scores.continuous.interval_score

Also, while you can wait until you have finished your work before opening a pull request, it is also completely fine to open a draft pull request part way through and request feedback part way through.

@lbluett
Copy link
Contributor

lbluett commented Nov 25, 2024

@BethEbert requested that we add Spearman rank correlation in #309

It should be straightforward to create using xr.cov and xr.std

Any objections to implementing this using xr.corr like Pearson's correlation is calculated?

@lbluett
Copy link
Contributor

lbluett commented Nov 25, 2024

@lbluett just a heads up that over time scores has refined what we include in docstrings.

Here are some links to some recently written docstrings, which can serve as guides/templates:

KGE: https://scores.readthedocs.io/en/stable/api.html#scores.continuous.kge Interval Score: https://scores.readthedocs.io/en/stable/api.html#scores.continuous.interval_score

Also, while you can wait until you have finished your work before opening a pull request, it is also completely fine to open a draft pull request part way through and request feedback part way through.

Thanks Steph, appreciate your guidance. I'll open a draft shortly regarding my question above.

@tennlee
Copy link
Collaborator

tennlee commented Nov 25, 2024

@BethEbert requested that we add Spearman rank correlation in #309
It should be straightforward to create using xr.cov and xr.std

Any objections to implementing this using xr.corr like Pearson's correlation is calculated?

I would presume is should be fine. I'll ask someone who's familiar with that part of the codebase to chime in.

ping @nicholasloveday .

@lbluett lbluett linked a pull request Nov 26, 2024 that will close this issue
20 tasks
@tennlee tennlee linked a pull request Nov 26, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new metric Adding a new metric or score
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants