Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progressive web app #789

Merged
merged 72 commits into from
Mar 10, 2021
Merged

progressive web app #789

merged 72 commits into from
Mar 10, 2021

Conversation

dodumosu
Copy link
Collaborator

@dodumosu dodumosu commented Feb 9, 2021

the pull request addresses nditech/apollo-issues#104

this commit:
- removes the explicit location field. instead, the location is updated
  when the submission is saved/posted
- for integer fields, typing in a value outside the preset range
  shows an invalid input message. it *does not* prevent the data from
  getting sent though
@dodumosu dodumosu marked this pull request as ready for review March 10, 2021 13:52
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@takinbo takinbo merged commit e198b36 into nditech:develop Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants