Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor cleanup #812

Merged
merged 2 commits into from
Jun 3, 2021
Merged

minor cleanup #812

merged 2 commits into from
Jun 3, 2021

Conversation

dodumosu
Copy link
Collaborator

@dodumosu dodumosu commented Jun 2, 2021

this pull request makes the following changes:

  • use the DEBUG flag to track errors in the PWA instead of having a separate flag;
  • removes a logging statement in the PWA frontend

@dodumosu dodumosu requested a review from takinbo June 2, 2021 10:38
takinbo
takinbo approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@takinbo takinbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takinbo takinbo merged commit b62e47e into nditech:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takinbo takinbo takinbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodumosu @takinbo